Add type annotations to part of the public API #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
basnijholt
force-pushed
the
typing
branch
3 times, most recently
from
f8f4f45
to
e094318
Compare
basnijholt
commented
Sep 9, 2024
| @@ -26,8 +26,6 @@ | |||
|
|
|||
| """Provider for IonQ backends""" | |||
|
|
|||
| import warnings | |||
Cynocracy
approved these changes
Sep 9, 2024
|
Looks great, thanks for adding @basnijholt ! |
basnijholt
commented
Sep 9, 2024
| @@ -78,7 +78,7 @@ | |||
| "Topic :: Scientific/Engineering", | |||
| ], | |||
| keywords="qiskit sdk quantum", | |||
| python_requires=">=3.7", | |||
| python_requires=">=3.9", | |||
There was a problem hiding this comment.
Python 3.7 is already EOL and 3.8 will be at the end of this month.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments