[Docs] Wording & formatting changes in the Tapping Force Hold section of the Tap Hold page + removed trailing whitespaces #10391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Permissive Hold and the Ignore Mod Tap Interrupt sections were also modified to remove the quotes around "tapping".
precondition
changed the title
fauxpark
approved these changes
Sep 22, 2020
precondition
force-pushed
the
tapping-force-hold-docs
branch
from
a3507e1
to
d871d4c
Compare
ridingqwerty
requested changes
Sep 26, 2020
Used the gerund form of "to keep" in the Tapping Force Hold section of the Tap Hold docs. Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
|
Thanks! |
tomohisa
pushed a commit
to tomohisa/qmk_firmware
that referenced
this pull request
Sep 28, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (3643 commits) Swapparoo of bottom row keys (qmk#10277) [Keyboard] Add PloopyCo devices (qmk#7935) Keyboard update: SL40 (qmk#10445) [keyboard] Add SP-111 support (qmk#10193) Add logic for AT90USBxx7 where needed (qmk#10203) Trifecta Keymap [Docs] Wording & formatting changes in the Tapping Force Hold section of the Tap Hold page + removed trailing whitespaces (qmk#10391) `setrgb()`: Use arrow operator (qmk#10451) [Keyboard] add Percent Canoe Gen2 (qmk#10344) [Keyboard] add hannah65 by Team Mechlovin (qmk#10284) Fix Belgian sendstring properly (qmk#10444) Add VIA support for lazydesigners/the30 (qmk#10374) [Keyboard] add duckboard by doodboard (qmk#10318) Fix Belgian sendstring file (qmk#10443) [Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394) CLI/Doctor: Print QMK_HOME (qmk#10398) Add Wyvern Keyboard (qmk#10378) Adding Bear 65 Ergo Keyboard To QMK (qmk#10384) VIA Support: Gray Studio HB85 (qmk#10329) format code according to conventions [skip ci] ...
rgoulter
pushed a commit
to rgoulter/qmk_firmware
that referenced
this pull request
Oct 4, 2020
… of the Tap Hold page + removed trailing whitespaces (qmk#10391) * Wording & formatting changes in Tapping Force Hold The Permissive Hold and the Ignore Mod Tap Interrupt sections were also modified to remove the quotes around "tapping". * Removed all trailing whitespaces from tap hold doc * "it's simply really:" → "it's simple really:" * "This allows to keep the ability" → "This allows keeping the ability" Used the gerund form of "to keep" in the Tapping Force Hold section of the Tap Hold docs. Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
… of the Tap Hold page + removed trailing whitespaces (qmk#10391) * Wording & formatting changes in Tapping Force Hold The Permissive Hold and the Ignore Mod Tap Interrupt sections were also modified to remove the quotes around "tapping". * Removed all trailing whitespaces from tap hold doc * "it's simply really:" → "it's simple really:" * "This allows to keep the ability" → "This allows keeping the ability" Used the gerund form of "to keep" in the Tapping Force Hold section of the Tap Hold docs. Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
… of the Tap Hold page + removed trailing whitespaces (qmk#10391) * Wording & formatting changes in Tapping Force Hold The Permissive Hold and the Ignore Mod Tap Interrupt sections were also modified to remove the quotes around "tapping". * Removed all trailing whitespaces from tap hold doc * "it's simply really:" → "it's simple really:" * "This allows to keep the ability" → "This allows keeping the ability" Used the gerund form of "to keep" in the Tapping Force Hold section of the Tap Hold docs. Co-authored-by: ridingqwerty <george.g.koenig@gmail.com> Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I corrected the incorrect "this repeats the tapped key rather to hold a modifier key." and used the opportunity to reword that paragraph in the Tapping Force Hold section a bit to make it clearer what is the default behaviour, and contrasted it with the
TAPPING_FORCE_HOLDbehaviour and let it know that it applies to all dual-role keys, not just mod-taps.Additionally, I also formatted the example by putting the pressed keys between backticks as done everywhere else in the Tap Hold configuration settings documentation page.
Then, I also replaced the "tapping" in "One Shot Tapping Toggle" by simply "tap" because that's what the One-Shot documentation page uses exclusively.
Finally, I removed the quotes around the word "tapping" in
the "tapping" functionbecause they're unnecessary.EDIT: A second commit removing all trailing whitespaces in the Tap Hold configuration settings page was added.
Types of Changes
Issues Fixed or Closed by This PR
Checklist