Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trifecta Keymap Revision #10457

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Trifecta Keymap Revision #10457

merged 1 commit into from
Sep 28, 2020

Conversation

2Moons-JP
Copy link
Contributor

Description

Minor Trifecta keymap revision. RGB_TOG left over from testing.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@2Moons-JP 2Moons-JP changed the title Trifecta Keymap revision Trifecta Keymap Revision Sep 27, 2020
@zvecr zvecr added keymap via Adds via keymap and/or updates keyboard for via support labels Sep 27, 2020
@zvecr zvecr requested a review from a team September 27, 2020 22:05
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 45c2a05 into qmk:master Sep 28, 2020
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@fauxpark
Merge pull request qmk#10457 from 2Moons-JP/trifecta_keymap
3867440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2Moons-JP @fauxpark @zvecr