Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configurator layout helix/rev3_4rows #10618

Merged

Conversation

MakotoKurauchi
Copy link
Contributor

Description

Fixed an issue where the layout of helix/rev3_4rows was broken in qmk configurator.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The result of qmk info -kb helix/rev3_4rows -km default -m is now correct.

@mtei mtei requested a review from a team October 12, 2020 11:26
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 2d4ae0f into qmk:master Oct 12, 2020
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
Co-authored-by: keyaki-namiki <28521374+keyaki-namiki@users.noreply.github.com>
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
Co-authored-by: keyaki-namiki <28521374+keyaki-namiki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants