-
-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial beta firmware for the Rocketboard-16 macro/num pad #10688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s do not work and needs cleaning up
… really bright), added the ability to switch LED mode with left encoder click, and added via support (untested)
Merging upstream main project with forked master
drashna
requested changes
Oct 18, 2020
Co-authored-by: Drashna Jaelre <drashna@live.com>
fauxpark
requested changes
Oct 19, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
approved these changes
Oct 19, 2020
fauxpark
requested changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, actually this is missing an info.json.
fauxpark
approved these changes
Oct 19, 2020
… idea - but it works!
fauxpark
requested changes
Oct 20, 2020
- Changed the dimming step size for smoother dimming with the reduced range - Added lots of OLED functionality - QMK logo and title at top, num/caps/scroll lock status, and backlight brightness level - Updated the rules.mk file to comply more closely with the formatting guidelines
fauxpark
requested changes
Oct 20, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
approved these changes
Oct 21, 2020
drashna
requested changes
Oct 23, 2020
drashna
approved these changes
Nov 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oscarcarlsson
pushed a commit
to oscarcarlsson/qmk_firmware
that referenced
this pull request
Nov 2, 2020
* Firmware initial commit, still has a few bugs - mainly rotary encoders do not work and needs cleaning up * Fixed the volume control issue and limited the RGB brightness (can be really bright), added the ability to switch LED mode with left encoder click, and added via support (untested) * Remove define that should go in config.h * Removed define that should be in config.h * Removed LTO_ENABLE as suggested - has issues on ARM Co-authored-by: Drashna Jaelre <drashna@live.com> * Added the correct define for OLED screen size * Applied suggested change to remove description Co-authored-by: Ryan <fauxpark@gmail.com> * Made suggested change to remove backslashes Co-authored-by: Ryan <fauxpark@gmail.com> * Suggested change made to rgblight Co-authored-by: Ryan <fauxpark@gmail.com> * Suggested change made to rgblight Co-authored-by: Ryan <fauxpark@gmail.com> * Suggested change made to remove backslashes Co-authored-by: Ryan <fauxpark@gmail.com> * Suggested change made to rgblight Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/rocketboard_16/rocketboard_16.c Co-authored-by: Ryan <fauxpark@gmail.com> * Added suggested comments Co-authored-by: Ryan <fauxpark@gmail.com> * Made suggested changes to rules file Co-authored-by: Ryan <fauxpark@gmail.com> * Added suggested change to rgblight Co-authored-by: Ryan <fauxpark@gmail.com> * Added info.json for QMK configurator * Update readme.md * This change makes the firmware work... through magic... seriously, no idea - but it works! * Updated dimming step, OLED functionality, and rules for formatting - Changed the dimming step size for smoother dimming with the reduced range - Added lots of OLED functionality - QMK logo and title at top, num/caps/scroll lock status, and backlight brightness level - Updated the rules.mk file to comply more closely with the formatting guidelines * Fixed tab issues Co-authored-by: Ryan <fauxpark@gmail.com> * Updated to use bootmagic lite with the key that usually turns rgb on/off Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
2 tasks
ringmaster
pushed a commit
to ringmaster/qmk_firmware
that referenced
this pull request
Nov 5, 2020
* Firmware initial commit, still has a few bugs - mainly rotary encoders do not work and needs cleaning up * Fixed the volume control issue and limited the RGB brightness (can be really bright), added the ability to switch LED mode with left encoder click, and added via support (untested) * Remove define that should go in config.h * Removed define that should be in config.h * Removed LTO_ENABLE as suggested - has issues on ARM Co-authored-by: Drashna Jaelre <drashna@live.com> * Added the correct define for OLED screen size * Applied suggested change to remove description Co-authored-by: Ryan <fauxpark@gmail.com> * Made suggested change to remove backslashes Co-authored-by: Ryan <fauxpark@gmail.com> * Suggested change made to rgblight Co-authored-by: Ryan <fauxpark@gmail.com> * Suggested change made to rgblight Co-authored-by: Ryan <fauxpark@gmail.com> * Suggested change made to remove backslashes Co-authored-by: Ryan <fauxpark@gmail.com> * Suggested change made to rgblight Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/rocketboard_16/rocketboard_16.c Co-authored-by: Ryan <fauxpark@gmail.com> * Added suggested comments Co-authored-by: Ryan <fauxpark@gmail.com> * Made suggested changes to rules file Co-authored-by: Ryan <fauxpark@gmail.com> * Added suggested change to rgblight Co-authored-by: Ryan <fauxpark@gmail.com> * Added info.json for QMK configurator * Update readme.md * This change makes the firmware work... through magic... seriously, no idea - but it works! * Updated dimming step, OLED functionality, and rules for formatting - Changed the dimming step size for smoother dimming with the reduced range - Added lots of OLED functionality - QMK logo and title at top, num/caps/scroll lock status, and backlight brightness level - Updated the rules.mk file to comply more closely with the formatting guidelines * Fixed tab issues Co-authored-by: Ryan <fauxpark@gmail.com> * Updated to use bootmagic lite with the key that usually turns rgb on/off Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hardware setup should all be correct, working on establishing the default keymap for certain and other functionality - i.e. the OLED display currently only has test text output on it. Most importantly need to ensure Via support with main branch.
Types of Changes
Full keyboard addition - initial commit
Issues Fixed or Closed by This PR
Checklist