Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] ANAVI Macro Pad 8 fix kodi and default #10727

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

leon-anavi
Copy link
Contributor

Improvements and bug fixes for the keymaps kodi and default for
ANAVI Macro Pad 8:

  • Add space to the end of string "Active layer: " for better
    visibility on the mini I2C OLED display for both keymaps
  • Replace "Main" with "Kodi" for the Kodi keymap
  • Add comment with reference to Kodi documentation for the
    available shortcuts in this keymap

Signed-off-by: Leon Anavi leon@anavi.org

Description

Improvements and bug fixes for the keymaps kodi and default for ANAVI Macro Pad 8 as explained in the git commit message.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Improvements and bug fixes for the keymaps kodi and default for
ANAVI Macro Pad 8:

- Add space to the end of string "Active layer: " for better
  visibility on the mini I2C OLED display for both keymaps
- Replace "Main" with "Kodi" for the Kodi keymap
- Add comment with reference to Kodi documentation for the
  available shortcuts in this keymap

Signed-off-by: Leon Anavi <leon@anavi.org>
@leon-anavi
Copy link
Contributor Author

Hi,

Kind reminder about this pull request with minor changes submitted ~3 weeks ago. Could you please have a look?

Thanks,
Leon

@drashna drashna requested a review from a team November 15, 2020 19:37
@drashna drashna merged commit 3c156e1 into qmk:master Nov 17, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
Improvements and bug fixes for the keymaps kodi and default for
ANAVI Macro Pad 8:

- Add space to the end of string "Active layer: " for better
  visibility on the mini I2C OLED display for both keymaps
- Replace "Main" with "Kodi" for the Kodi keymap
- Add comment with reference to Kodi documentation for the
  available shortcuts in this keymap

Signed-off-by: Leon Anavi <leon@anavi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants