-
-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Udev related fixes and improvements #10736
Conversation
I'm not sure that using As for ModemManager, it could be running even without systemd (at least Void Linux has the corresponding package, but I don't have any hardware which actually needs it), therefore removing the warning completely for such systems might not be 100% correct. |
Yes, ModemManager: This PR does not remove any functionality, as we currently only test MM if |
After doing some testing with the help of D3vastat0r and Dasky from Discord, the Also,
The output should be more informative, especially for new-comers. |
Not all udev implementations support 'RUN{builtin}+="uaccess"' so we only check it on systemd systems where systemd-udevd is likely used.
b25d4ed
to
48de502
Compare
Matching is case-sensitive and according http://www.linux-usb.org/usb.ids and my personal experience, Linux only uses lower-case letters.
48de502
to
3a7bcab
Compare
Description
Only check ModemManager if Caterina udev rule is not found.
Not all udev implementations support 'RUN{builtin}+="uaccess"', so we only check it on systemd systems where
systemd-udevd
is likely used.@sigprof could you test it with
eudev
?Types of Changes
Issues Fixed or Closed by This PR
Checklist