Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mt84 keyboard #10857

Merged
merged 44 commits into from
Dec 7, 2020
Merged

add mt84 keyboard #10857

merged 44 commits into from
Dec 7, 2020

Conversation

maikongk
Copy link
Contributor

@maikongk maikongk commented Nov 4, 2020 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 4, 2020
drashna
drashna requested changes Nov 15, 2020
View reviewed changes
keyboards/mt84/config.h Show resolved Hide resolved
keyboards/mt84/config.h Outdated Show resolved Hide resolved
keyboards/mt84/config.h Outdated Show resolved Hide resolved
keyboards/mt84/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/mt84/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mt84/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/mt84/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/mt84/mt84.c Show resolved Hide resolved
keyboards/mt84/mt84.h Show resolved Hide resolved
@drashna drashna requested a review from a team November 15, 2020 21:39
Erovia
Erovia requested changes Nov 25, 2020
View reviewed changes
keyboards/mt84/readme.md Outdated Show resolved Hide resolved
keyboards/mt84/mt84.c Outdated Show resolved Hide resolved
keyboards/mt84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mt84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mt84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mt84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mt84/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mt84/config.h Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Nov 29, 2020
View reviewed changes
keyboards/mt84/rules.mk Outdated Show resolved Hide resolved
@noroadsleft noroadsleft requested a review from a team November 29, 2020 18:14
fauxpark
fauxpark requested changes Nov 29, 2020
View reviewed changes
keyboards/mt84/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mt84/readme.md Show resolved Hide resolved
fauxpark
fauxpark requested changes Dec 1, 2020
View reviewed changes
keyboards/mt84/readme.md Outdated Show resolved Hide resolved
Erovia
Erovia requested changes Dec 2, 2020
View reviewed changes
keyboards/mt84/config.h Outdated Show resolved Hide resolved
keyboards/mt84/readme.md Show resolved Hide resolved
@Erovia Erovia requested a review from a team December 2, 2020 19:32
Erovia
Erovia requested changes Dec 6, 2020
View reviewed changes
keyboards/mt84/readme.md Show resolved Hide resolved
keyboards/mt84/readme.md Show resolved Hide resolved
@Erovia Erovia merged commit 10f7f60 into qmk:master Dec 7, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@maikongk @drashna @xgnxs
add mt84 keyboard (qmk#10857)
efec194 
Co-authored-by: Drashna Jaelre <drashna@live.com>
mgmanzella pushed a commit to mgmanzella/qmk_firmware that referenced this pull request Feb 16, 2021
@maikongk @drashna @mgmanzella
add mt84 keyboard (qmk#10857)
27598ae 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maikongk @drashna @Erovia @fauxpark @noroadsleft