Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update one_shot_keys.md #10917

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Update one_shot_keys.md #10917

merged 1 commit into from
Nov 18, 2020

Conversation

j-zero
Copy link
Contributor

@j-zero j-zero commented Nov 11, 2020

set_oneshot_mods(); needs to use MOD_BIT(KC_*) not MOD_*
MOD_RSFT doesn't work. See: #10901

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@j-zero
Update one_shot_keys.md
fb2cbc4 
MOD_RSFT doesn't work. See: qmk#10901
@drashna drashna requested a review from a team November 17, 2020 00:52
@zvecr zvecr merged commit 078586b into qmk:master Nov 18, 2020
@zvecr
Copy link
Member

zvecr commented Nov 18, 2020

Thanks!

xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@j-zero @xgnxs
Update one_shot_keys.md (qmk#10917)
82123c2 
MOD_RSFT doesn't work. See: qmk#10901
@zvecr zvecr mentioned this pull request Aug 28, 2022
Closed
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@j-zero
Update one_shot_keys.md (qmk#10917)
d335c1b 
MOD_RSFT doesn't work. See: qmk#10901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-zero @zvecr @drashna @fauxpark