Reduce travis load by replacing an exclusive grep with an inclusive grep #10964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
reviewed
Nov 18, 2020
| @@ -12,6 +12,7 @@ TRAVIS_COMMIT_RANGE="${TRAVIS_COMMIT_RANGE:-HEAD~1..HEAD}" | |||
| # Extra variables | |||
| LOCAL_BRANCH=$(git rev-parse --abbrev-ref HEAD) | |||
| QMK_CHANGES=$(git diff --name-only -n 1 ${TRAVIS_COMMIT_RANGE}) | |||
| NUM_CORE_CHANGES=$(echo "$QMK_CHANGES" | grep -Ec -e '^Makefile' -e '^[^/]*.mk' -e '^drivers/' -e '^lib/atsam' -e '^lib/lib8tion/' -e '^platforms' -e '^quantum' -e '^tests' -e '^tmk_core') | |||
There was a problem hiding this comment.
If I have understood the grep correctly, are the submodules excluded here for a reason?
I can see a valid cases both ways:
- we want to build everything when a submodule changes to check for compatibility
- users unknowingly push old/wrong submodules
There was a problem hiding this comment.
I'm happy to go either way here. I don't have a reason to have excluded them other than initially pulling in things that are actually in qmk_firmware.
For #2 we might be better off having a lint check anyway.
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
…rep (qmk#10964) * add -n to avoid compiling * switch to an include rather than exclude strategy
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…rep (qmk#10964) * add -n to avoid compiling * switch to an include rather than exclude strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently a lot of things trigger full builds that shouldn't. This changes our core code identification strategy from "all directories we haven't excluded" to "all directories we have explicitly included."
Types of Changes
Checklist