Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add VBUS hack for teensys #10986

Merged
merged 4 commits into from
Nov 28, 2020
Merged

[Docs] Add VBUS hack for teensys #10986

merged 4 commits into from
Nov 28, 2020

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 20, 2020

Description

Adds section on how to add VBUS support to Teensy 2.0 and Teensy++ 2.0, so that Split USB Detect isn't needed.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from zvecr and a team November 20, 2020 17:57
@drashna drashna requested a review from a team November 21, 2020 20:17
fauxpark
fauxpark requested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some slight tweaks, LGTM otherwise.

docs/feature_split_keyboard.md Outdated Show resolved Hide resolved
docs/feature_split_keyboard.md Outdated Show resolved Hide resolved
docs/feature_split_keyboard.md Outdated Show resolved Hide resolved
@drashna @fauxpark
Minor doc tweaks
ae9cc9d 
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark fauxpark requested a review from a team November 26, 2020 23:51
noroadsleft
noroadsleft requested changes Nov 27, 2020
View reviewed changes
docs/feature_split_keyboard.md Outdated Show resolved Hide resolved
@drashna @noroadsleft
use the right term because it's a weird word
7c0397e 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft noroadsleft merged commit 16d55b1 into qmk:master Nov 28, 2020
@noroadsleft
Copy link
Member

Thanks!

@drashna drashna deleted the docs/teensy_vbus branch November 28, 2020 23:56
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@drashna @xgnxs
[Docs] Add VBUS hack for teensys (qmk#10986)
3ab7b6c
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
[Docs] Add VBUS hack for teensys (qmk#10986)
d517547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @noroadsleft @fauxpark