Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rart4x4 and via support #11095

Merged
merged 15 commits into from
Dec 16, 2020
Merged

Add Rart4x4 and via support #11095

merged 15 commits into from
Dec 16, 2020

Conversation

alabahuy
Copy link
Contributor

@alabahuy alabahuy commented Dec 1, 2020 •
edited
Loading

Description

add new keyboard with layout ortho 4x4 and support via

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 1, 2020
@zvecr zvecr requested a review from a team December 1, 2020 20:49
zvecr
zvecr requested changes Dec 4, 2020
View reviewed changes
keyboards/rart/rart4x4/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team December 4, 2020 00:57
@drashna drashna requested a review from a team December 4, 2020 05:37
@alabahuy
Copy link
Contributor Author

alabahuy commented Dec 8, 2020

any update @zvecr ?

@alabahuy alabahuy mentioned this pull request Dec 9, 2020
Merged
6 tasks
@noroadsleft noroadsleft merged commit 11669bb into qmk:master Dec 16, 2020
@noroadsleft
Copy link
Member

Thanks!

xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@rezaadio @xgnxs
[Keyboard] Add rart/rart4x4 with VIA support (qmk#11095)
b5f0c95 
* Create config.h

* Create info.json

* Create rart4x4.c

* Create rart4x4.h

* Create readme.md

* Create rules.mk

* Create keymap.c

* Create keymap.c

* Rename keyboards/rart/rart4x4/default/keymap.c to keyboards/rart/rart4x4/keymaps/default/keymap.c

* Rename keyboards/rart/rart4x4/via/keymap.c to keyboards/rart/rart4x4/keymaps/via/keymap.c

* Create rules.mk

* Update info.json

* Update keymap.c

* Update rart4x4.h

* Update rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alabahuy @noroadsleft @drashna @fauxpark @zvecr @rezaadio