Partial fix for Issue #9405 - Caps Lock not working with Unicode Map's XP on Linux #11232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patch applied locally and verified to work on Linux (arch). |
Erovia
approved these changes
Dec 22, 2020
fauxpark
approved these changes
Dec 22, 2020
|
Thanks! |
3 tasks
nblyumberg
pushed a commit
to nblyumberg/qmk_firmware
that referenced
this pull request
Dec 31, 2020
…ap's XP on Linux (qmk#11232)
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
…ap's XP on Linux (qmk#11232)
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 13, 2021
…ap's XP on Linux (qmk#11232)
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…ap's XP on Linux (qmk#11232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a partial fix for Issue #9405 [One-shot Shift and Caps Lock not working with Unicode Map's XP on Linux].
The One-shot Shift part of the issue is addressed in PR #11220.
Note: This PR depends on #11220 being merged to work correctly!
As discussed in the bug, Ctrl+Shift+U to input Unicode characters does not work when Caps Lock is activated. This symptom is seen in most Linux distros, and also in ChromeOS. It's my opinion that the Linux and ChromeOS behavior is broken. To that end:
https://bugs.chromium.org/p/chromium/issues/detail?id=1159242
https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/1325747
This PR creates a workaround in QMK to unset Caps Lock before sending Ctrl-Shift-U, and then turn Caps Lock back on after the unicode sequence has been entered.
I would very much appreciate if others could test this with various Linux distros and other Linux-like OS types, to verify that it is broadly compatible.
Types of Changes
Issues Fixed or Closed by This PR
Checklist