Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bastyl mini keyboard #11782

Merged
merged 19 commits into from
Feb 12, 2021
Merged

Add bastyl mini keyboard #11782

merged 19 commits into from
Feb 12, 2021

Conversation

bstiq
Copy link
Contributor

@bstiq bstiq commented Feb 3, 2021

Description

Add the files for the Bastyl Mini keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [ x] Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

.

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Regards,

drashna
drashna requested changes Feb 5, 2021
View reviewed changes
keyboards/bastardkb/bastylmini/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team February 5, 2021 07:11
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/config.h
3d20cdd 
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
drashna requested changes Feb 6, 2021
View reviewed changes
keyboards/bastardkb/bastylmini/bastylmini.h Outdated Show resolved Hide resolved
keyboards/bastardkb/bastylmini/info.json Outdated Show resolved Hide resolved
keyboards/bastardkb/bastylmini/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/bastardkb/bastylmini/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/bastardkb/bastylmini/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/bastardkb/bastylmini/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/bastardkb/bastylmini/rules.mk Show resolved Hide resolved
keyboards/bastardkb/bastylmini/config.h Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Feb 8, 2021
View reviewed changes
keyboards/bastardkb/bastylmini/bastylmini.h Outdated Show resolved Hide resolved
keyboards/bastardkb/bastylmini/info.json Outdated Show resolved Hide resolved
keyboards/bastardkb/bastylmini/rules.mk Outdated Show resolved Hide resolved
bstiq and others added 15 commits February 10, 2021 11:51
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/bastylmini.h
6a67352 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/keymaps/default/keymap.c
fd7b3d1 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/info.json
9b998ef 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/keymaps/default/keymap.c
a2f17ba 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/keymaps/default/keymap.c
0f15170 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/keymaps/default/keymap.c
046c750 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/rules.mk
f5ef0f1 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bstiq @drashna
Update keyboards/bastardkb/bastylmini/config.h
08115cb 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@bstiq @noroadsleft
Update keyboards/bastardkb/bastylmini/bastylmini.h
33626c9 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@bstiq @noroadsleft
Update keyboards/bastardkb/bastylmini/info.json
84d33cc 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@bstiq @noroadsleft
Update keyboards/bastardkb/bastylmini/rules.mk
1f51682 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@bstiq @NullSense
Update keyboards/bastardkb/bastylmini/config.h
0d1c085 
Co-authored-by: NullSense <matas234@gmail.com>
@bstiq @NullSense
Update keyboards/bastardkb/bastylmini/config.h
99c1a10 
Co-authored-by: NullSense <matas234@gmail.com>
@bstiq @NullSense
Update keyboards/bastardkb/bastylmini/rules.mk
37d7e15 
Co-authored-by: NullSense <matas234@gmail.com>
@bstiq @NullSense
Update keyboards/bastardkb/bastylmini/rules.mk
7964bcc 
Co-authored-by: NullSense <matas234@gmail.com>
@bstiq
Copy link
Contributor Author

bstiq commented Feb 10, 2021

Hi, the CI fail seems to be related to the tap dance. I don't know anything about tap dance, should I just remove the define from the rules ? @NullSense @drashna

Thanks for your help !

@NullSense
Copy link

Hi, the CI fail seems to be related to the tap dance. I don't know anything about tap dance, should I just remove the define from the rules ? @NullSense @drashna

Thanks for your help !

I'm not sure why this is happening, maybe the others can help.

@NullSense
Copy link

https://github.com/NullSense/dots/blob/master/readme.md you could also add a nice readme for users new to the keyboard to easily preview the layout (or adding comments above each layer).

@drashna
Copy link
Member

drashna commented Feb 12, 2021

Thanks!

@drashna drashna merged commit 550359a into qmk:master Feb 12, 2021
NullSense added a commit to NullSense/qmk_firmware that referenced this pull request Feb 25, 2021
@bstiq @drashna
@noroadsleft @NullSense
[Keyboard] Add bastyl mini keyboard (qmk#11782)
ec5058a 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: NullSense <matas234@gmail.com>
rclasen pushed a commit to rclasen/qmk_firmware that referenced this pull request Aug 16, 2021
@bstiq @drashna
@noroadsleft @NullSense @rclasen
[Keyboard] Add bastyl mini keyboard (qmk#11782)
ea37bff 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: NullSense <matas234@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullSense NullSense NullSense left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bstiq @NullSense @drashna @fauxpark @noroadsleft