Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unscramble Durgod k320 keymap / fix Issue #11883 #11885

Merged
merged 2 commits into from
Feb 14, 2021

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Feb 13, 2021

Description

As noted in Issue #11883 and in the comments on PR #11778, the Durgod k320 LAYOUT_tkl_ansi macro does not match the physical keyboard layout, or the layout recorded in info.json, resulting in garbled unusable key mappings when using the QMK configurator. The unusually organized layout macro also makes it very hard to write a manual keyboard layout since the keys in the layout macro are not in an order that one can make sense of.

This PR updates the layout to be aligned with the physical keyboard and with the info.json.

Kudos to @baruch for noticing the problem and raising the issue, including a proposed updated LAYOUT_tkl_ansi macro.

Notes:

  • I have verified that this compiles, but I do not have a Durgod k320 with which to test the code. I would appreciate if someone who has that keyboard could test.
  • I have targeted develop with this PR, since this definitely will break existing keymaps.
  • I have targeted master with this PR even though it may break existing keymaps, because the configurator is broken, and all of the existing keymaps are patched here.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@spidey3 spidey3 marked this pull request as draft February 13, 2021 18:06
@spidey3 spidey3 marked this pull request as ready for review February 13, 2021 18:27
@baruch
Copy link

baruch commented Feb 13, 2021

@spidey3 I tested the default keymap and it works fine.

Since this keyboard is new in QMK I personally think the fix can go to master and quickly eliminate any chance for someone to stumble upon the incorrect layout.

@spidey3 spidey3 changed the base branch from develop to master February 14, 2021 01:20
@spidey3 spidey3 merged commit 537b761 into qmk:master Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Durgod K320 layout macro is wrong
4 participants