(Re)Fixing K-type RGB lighting #12084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maps without RGB matrix enabled
He did... it's on my to-do list on a more general level -- multi-instance I2C and SPI are part of the plan. I think he was hoping we could just get yours in, but sadly it's not that simple! For now, I'd just disregard that request -- once your implementation is proven we can use it as prior art. |
fauxpark
requested changes
Mar 3, 2021
drashna
approved these changes
Mar 3, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
drashna
approved these changes
Mar 3, 2021
|
FYI, I Have tested this PR on my k-type and it works great ! |
fauxpark
approved these changes
Mar 25, 2021
tzarc
approved these changes
Mar 25, 2021
mrlinuxfish
pushed a commit
to mrlinuxfish/qmk_firmware
that referenced
this pull request
Mar 28, 2021
* initial rgb driver fix * added underglow LEDs and fixed typo in RGB locations * removed test code * added my key maps * updated rgb keymap to work with changes * refactored my code to make it more maintainable and updated keymaps. * added GPL licence * Turned off matrix scan rate debug info * added checks if RGB matrix is enabled to fix errors when building keymaps without RGB matrix enabled * Apply suggestions from code review by fauxpark Co-authored-by: Ryan <fauxpark@gmail.com> * Renamed led driver file to be less ambiguous * Renamed is31fl3733 driver files to is31fl3733-dual Co-authored-by: Ryan <fauxpark@gmail.com>
mrtnee
pushed a commit
to mrtnee/qmk_firmware
that referenced
this pull request
Nov 20, 2021
* initial rgb driver fix * added underglow LEDs and fixed typo in RGB locations * removed test code * added my key maps * updated rgb keymap to work with changes * refactored my code to make it more maintainable and updated keymaps. * added GPL licence * Turned off matrix scan rate debug info * added checks if RGB matrix is enabled to fix errors when building keymaps without RGB matrix enabled * Apply suggestions from code review by fauxpark Co-authored-by: Ryan <fauxpark@gmail.com> * Renamed led driver file to be less ambiguous * Renamed is31fl3733 driver files to is31fl3733-dual Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes to the K-type RGB driver so that it doesn't break master
Description
This PR is a follow up to #11551
I have made some changes that (hopefully) fix the issues when it was initially merged into master. The problem seemed to be because I had some missing check to see if the RGB matrix was enabled or not.
@fauxpark also mentioned that some of these changes should be integrated into core. Currently there is a lot of code that relies on the i2c_master, so I am not exactly sure how it could be integrated.
Types of Changes
Issues Fixed or Closed by This PR
Checklist