Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LAYOUT_kc macros from edvorakjp keymaps #12217

Merged
merged 12 commits into from
Apr 10, 2021
Merged

Remove LAYOUT_kc macros from edvorakjp keymaps #12217

merged 12 commits into from
Apr 10, 2021

Conversation

epaew
Copy link
Contributor

@epaew epaew commented Mar 13, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

--

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Mar 16, 2021

余談ですが、、
もしもお望みなら、Helix キーボードで、ssd1306.c の代わりに QMK 標準の oled_driver.c を使えるようになりました。
キーマップの rules.mk に以下の1行を追加すれば使えます。

As a side note.
If you prefer, you can now use the QMK standard oled_driver.c instead of ssd1306.c on the Helix keyboard.
You can use it by adding the following line to the keymap rules.mk.

OLED_SELECT = core

helix/rev2/keymaps/default/oled_display.c も参考にしてください。
See also helix/rev2/keymaps/default/oled_display.c.

@epaew epaew marked this pull request as draft March 22, 2021 00:57
@epaew epaew force-pushed the feature/edvorakjp/remove_layout_kc branch 2 times, most recently from 260ea1a to 09ecc0d Compare March 22, 2021 11:49
@epaew epaew marked this pull request as ready for review March 22, 2021 11:49
@epaew
Copy link
Contributor Author

epaew commented Mar 22, 2021

@mtei
Thank you for your information! I updated my keymaps.

epaew added 12 commits March 27, 2021 07:56
@epaew
crkbd/edvorakjp: swap master
ccfd21b
@epaew
Run clang-format -style=file -i users/edvorakjp/*.{c,h}
9007442
@epaew
Updates users/edvorakjp
08318b4 
* update enum definitions for layers, custom keycodes and tap_dance codes
* update custom_tapping_term for ACTION_TAP_DANCE_FN_ADVANCED_TIME
* Add macros for keymap definitions
@epaew
Run `clang-format -style=file -i keyboards/crkbd/keymaps/edvorakjp/*.…
7492a34 
…{c,h}`
@epaew
[crkbd/edvorakjp keymap] Remove LAYOUT_kc macros
acb84c9
@epaew
Run `clang-format -style=file -i keyboards/keebio/iris/keymaps/edvora…
dbc9229 
…kjp/*.{c,h}`
@epaew
[iris/edvorakjp keymap] Remove LAYOUT_kc macros
56122c5
@epaew
Run `clang-format -style=file -i keyboards/helix/rev2/keymaps/edvorak…
75c4e59 
…jp/*.{c,h}`
@epaew
[helix/rev2/edvorakjp keymap] Remove LAYOUT_kc macros
4f67113
@epaew
Replace is_master with is_keyboard_left()
6b1d058
@epaew
[crkbd/keymaps/edvorakjp] Use QMK's native OLED driver instead of crk…
126014c 
…bd/rev1/legacy/ssd1306.{h,c}
@epaew
[helix/rev2/keymaps/edvorakjp] Use QMK's native OLED driver instead o…
0fc0996 
…f helix/local_drivers/ssd1306.{h,c}
@epaew epaew force-pushed the feature/edvorakjp/remove_layout_kc branch from f83330c to 0fc0996 Compare March 26, 2021 23:08
@mtei mtei requested a review from a team March 31, 2021 17:53
mtei
mtei approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mtei mtei requested a review from a team March 31, 2021 20:32
@drashna
Copy link
Member

drashna commented Apr 10, 2021

Thanks!

@drashna drashna merged commit 3dbb7f2 into qmk:master Apr 10, 2021
@epaew epaew deleted the feature/edvorakjp/remove_layout_kc branch April 10, 2021 00:43
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@epaew @makenova
[Keymap] Remove LAYOUT_kc macros from edvorakjp keymaps (qmk#12217)
9a055f7
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
@epaew @rizo
[Keymap] Remove LAYOUT_kc macros from edvorakjp keymaps (qmk#12217)
007d310
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
@epaew @toddyamakawa
[Keymap] Remove LAYOUT_kc macros from edvorakjp keymaps (qmk#12217)
d8328c6
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@epaew @HokieGeek
[Keymap] Remove LAYOUT_kc macros from edvorakjp keymaps (qmk#12217)
300afd8
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@epaew
[Keymap] Remove LAYOUT_kc macros from edvorakjp keymaps (qmk#12217)
3aa3ba0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtei mtei mtei approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epaew @mtei @drashna @fauxpark