Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roses Lite layout macro touch-up #12357

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

noroadsleft
Copy link
Member

Description

Arranges the layout macro and keymaps to mimic the keyboard layout.

[0] = LAYOUT(
KC_HOME, KC_GESC, KC_1, KC_2, KC_3, KC_4, KC_5, KC_6, KC_7, KC_8, KC_9, KC_0, KC_MINS, KC_EQL, KC_BSLS, KC_GRV, KC_PGUP,
KC_END, KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSPC, KC_PGDN,
KC_INS, KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_ENT, MO(1),
KC_LSFT, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT, KC_UP,
KC_RCTL, KC_LALT, KC_SPC, KC_LGUI, KC_SPC, KC_RALT, KC_LEFT, KC_DOWN, KC_RGHT
),

cc @vk2fgav (keyboard maintainer)

I made sure to verify that this doesn't result in different firmware – the resulting .HEX file is 100% identical with these changes.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Arranges the keycodes in the keymap to resemble the layout of the assembled hardware.
Use four-space indent and remove random tabs.
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 24, 2021
@noroadsleft noroadsleft requested a review from a team March 24, 2021 09:06
Copy link

@Reason0x6 Reason0x6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your addition, looks and build perfect

@fauxpark fauxpark merged commit e7cb7bc into qmk:master Mar 25, 2021
@noroadsleft noroadsleft deleted the cf/roseslite branch March 25, 2021 08:28
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request Mar 28, 2021
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants