Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add valor_frl_tkl info.json #12359

Merged
merged 2 commits into from
Mar 25, 2021
Merged

add valor_frl_tkl info.json #12359

merged 2 commits into from
Mar 25, 2021

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Mar 24, 2021 •
edited by fauxpark
Loading

Description

Add info.json for configurator as asked by @fauxpark

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@fauxpark fauxpark requested a review from a team March 24, 2021 11:05
@noroadsleft
Copy link
Member

@Xelus22 Does this board actually have the macro keys on the left? The info.json object should have as many keys as are assigned by keymap.c/expected by valor_frl_tkl.h, but this isn't the case:

image

@Xelus22
Copy link
Contributor Author

Xelus22 commented Mar 25, 2021

@Xelus22 Does this board actually have the macro keys on the left? The info.json object should have as many keys as are assigned by keymap.c/expected by valor_frl_tkl.h, but this isn't the case:

image

Yep you're right it doesnt, that is my bad. haha

@Xelus22
Copy link
Contributor Author

Xelus22 commented Mar 25, 2021

@noroadsleft should be ok now :D

noroadsleft
noroadsleft approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

👍

@noroadsleft noroadsleft merged commit 1ed48c7 into qmk:master Mar 25, 2021
@noroadsleft
Copy link
Member

Thanks!

mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request Mar 28, 2021
@Xelus22 @mrlinuxfish
add valor_frl_tkl info.json (qmk#12359)
5c0d7c2 
* add info.json

* remove macro keys to correct layout
@Xelus22 Xelus22 deleted the valor_frl_tkl_infojson branch June 2, 2021 11:31
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@Xelus22 @mrtnee
add valor_frl_tkl info.json (qmk#12359)
a729b4c 
* add info.json

* remove macro keys to correct layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @noroadsleft @fauxpark