Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YMDK Wings: enable Backlight #12714

Merged
merged 1 commit into from
Jun 20, 2021
Merged

YMDK Wings: enable Backlight #12714

merged 1 commit into from
Jun 20, 2021

Conversation

alittlepeace
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Backlighting was not enabled by default, and was turned on. Also took the opportunity to move rgblight_animations into the rest of the rgb settings for cleanup.
*

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark approved these changes Apr 27, 2021
View reviewed changes
keyboards/ymdk/wings/rules.mk Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team April 27, 2021 15:52
@noroadsleft noroadsleft changed the title Add files via upload YMDK Wings: enable Backlight Apr 27, 2021
@stale
Copy link

stale bot commented Jun 16, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@alittlepeace alittlepeace requested review from fauxpark and removed request for a team June 16, 2021 02:45
@stale stale bot removed the awaiting changes label Jun 16, 2021
@drashna
Copy link
Member

drashna commented Jun 20, 2021

Thanks!

@drashna drashna merged commit 1f4e20c into qmk:master Jun 20, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@alittlepeace @HokieGeek
[Keyboard] YMDK Wings: enable Backlight (qmk#12714)
bc31c4a
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@alittlepeace @wox
[Keyboard] YMDK Wings: enable Backlight (qmk#12714)
41c67ae
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@alittlepeace @nhongooi
[Keyboard] YMDK Wings: enable Backlight (qmk#12714)
8293528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alittlepeace @drashna @fauxpark