-
-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pass at data driven new-keyboard subcommand #12795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
zvecr
force-pushed
the
feature/new_keyboard2
branch
2 times, most recently
from
July 25, 2021 13:51
ab04947
to
f2fe96d
Compare
zvecr
changed the title
Initial pass at new keyboard subcommand
Initial pass at data driven new-keyboard subcommand
Oct 9, 2021
zvecr
force-pushed
the
feature/new_keyboard2
branch
2 times, most recently
from
November 4, 2021 19:34
c6a9489
to
bbac107
Compare
zvecr
force-pushed
the
feature/new_keyboard2
branch
from
November 4, 2021 23:02
49443b1
to
3bb9222
Compare
"none of the above" doesn't work.
|
zvecr
force-pushed
the
feature/new_keyboard2
branch
from
February 4, 2022 21:43
6ce62f3
to
dfcf139
Compare
github-actions
bot
added
keyboard
keymap
via
Adds via keymap and/or updates keyboard for via support
cli
qmk cli command
and removed
cli
qmk cli command
via
Adds via keymap and/or updates keyboard for via support
keymap
keyboard
labels
Feb 4, 2022
Should now be resolved in the short term |
tzarc
previously approved these changes
Feb 8, 2022
zvecr
force-pushed
the
feature/new_keyboard2
branch
from
February 8, 2022 18:57
5e94d11
to
8821e1d
Compare
tzarc
approved these changes
Feb 8, 2022
Erovia
added a commit
to Erovia/qmk_firmware
that referenced
this pull request
Feb 8, 2022
Make the output a little bit easier to read and provide more context to the user when the selected keyboard name is already used.
Erovia
added a commit
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on previous iterations by leaning on the community defaults and json schemas.
Types of Changes
Issues Fixed or Closed by This PR
Checklist