Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Use BASH if SHELL variable is not set (Windows) #12847

Merged
merged 1 commit into from
May 9, 2021
Merged

CLI: Use BASH if SHELL variable is not set (Windows) #12847

merged 1 commit into from
May 9, 2021

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented May 9, 2021

Description

It's possible that the $SHELL env var is not set in MSYS so instead of erroring out, fall back to BASH.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia Erovia requested a review from a team May 9, 2021 17:05
@github-actions github-actions bot added cli qmk cli command python labels May 9, 2021
@Erovia Erovia merged commit 30aae62 into qmk:master May 9, 2021
@Erovia Erovia deleted the fix/win_shell_fallback branch May 9, 2021 17:19
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
@Erovia @toddyamakawa
CLI: Use BASH if SHELL variable is not set (Windows) (qmk#12847)
ba1a3ff
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@Erovia @HokieGeek
CLI: Use BASH if SHELL variable is not set (Windows) (qmk#12847)
f92e41e
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Erovia @nhongooi
CLI: Use BASH if SHELL variable is not set (Windows) (qmk#12847)
ee640aa
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Erovia
CLI: Use BASH if SHELL variable is not set (Windows) (qmk#12847)
8903cbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erovia @fauxpark