Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding keymap for pistachio #12996

Merged
merged 4 commits into from
Jun 19, 2021
Merged

adding keymap for pistachio #12996

merged 4 commits into from
Jun 19, 2021

Conversation

7-rate
Copy link
Contributor

@7-rate 7-rate commented May 25, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels May 25, 2021
drashna
drashna requested changes May 27, 2021
View reviewed changes
keyboards/pistachio/keymaps/rate/keymap.c Outdated Show resolved Hide resolved
keyboards/pistachio/keymaps/rate/keymap.c Outdated Show resolved Hide resolved
keyboards/pistachio/keymaps/rate/keymap.c Outdated Show resolved Hide resolved
keyboards/pistachio/keymaps/rate/keymap.c Outdated Show resolved Hide resolved
keyboards/pistachio/keymaps/rate/keymap.c Outdated Show resolved Hide resolved
keyboards/pistachio/keymaps/rate/keymap.c Outdated Show resolved Hide resolved
keyboards/pistachio/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/pistachio/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@7-rate @drashna
Apply suggestions from code review
a1e3af7 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@7-rate
Copy link
Contributor Author

7-rate commented May 27, 2021

Thanks for the review.
I have responded to your suggestion.

@7-rate
Copy link
Contributor Author

7-rate commented Jun 9, 2021

What else can I do to merge?

@drashna drashna requested a review from a team June 16, 2021 04:31
@drashna
Copy link
Member

drashna commented Jun 16, 2021

What else can I do to merge?

It can take a while for us to get to PRs, as we do this in our free time.

And generally, we want two approved reviews before a PR gets merged.

@drashna drashna merged commit 7fefe12 into qmk:master Jun 19, 2021
@7-rate 7-rate mentioned this pull request Jun 19, 2021
Merged
6 tasks
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@7-rate @drashna @HokieGeek
[Keymap] adding keymap for pistachio (qmk#12996)
7801928 
Co-authored-by: Drashna Jaelre <drashna@live.com>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@7-rate @drashna @wox
[Keymap] adding keymap for pistachio (qmk#12996)
a736666 
Co-authored-by: Drashna Jaelre <drashna@live.com>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@7-rate @drashna @nhongooi
[Keymap] adding keymap for pistachio (qmk#12996)
7fe668e 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7-rate @drashna @fauxpark