Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Update ZSA Keyboard Readmes and keymaps #13041

Merged
merged 5 commits into from
Jul 26, 2021
Merged

[Keyboard] Update ZSA Keyboard Readmes and keymaps #13041

merged 5 commits into from
Jul 26, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented May 30, 2021

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 30, 2021 03:21
@stale
Copy link

stale bot commented Jul 14, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

fauxpark
fauxpark requested changes Jul 14, 2021
View reviewed changes
keyboards/moonlander/readme.md Outdated Show resolved Hide resolved
keyboards/ergodox_ez/rules.mk Outdated Show resolved Hide resolved
keyboards/ergodox_ez/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@drashna @fauxpark
Apply suggestions from code review
df0f81f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@stale stale bot removed the awaiting changes label Jul 14, 2021
fauxpark
fauxpark approved these changes Jul 15, 2021
View reviewed changes
keyboards/moonlander/readme.md Outdated Show resolved Hide resolved
@drashna @fauxpark
Fix inevitable typo
1fcd9a8 
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
fauxpark requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one, I promise 😅

keyboards/planck/ez/readme.md Outdated Show resolved Hide resolved
@drashna @fauxpark
Update keyboards/planck/ez/readme.md
45e0364 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit d45da3f into qmk:master Jul 26, 2021
@drashna drashna deleted the keyboard/planck_ez branch July 26, 2021 01:18
@yskoht yskoht mentioned this pull request Aug 9, 2021
Merged
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @fauxpark @nhongooi
[Keyboard] Update ZSA Keyboard Readmes and keymaps (qmk#13041)
6687a2c 
* [Keyboard] Update ZSA Keyboard Readmes and keymaps

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Remove custom rgb code for RGB_M_P

* Fix inevitable typo

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/planck/ez/readme.md

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @fauxpark