Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telophase cleanup #13225

Merged
merged 3 commits into from
Jun 20, 2021
Merged

Telophase cleanup #13225

merged 3 commits into from
Jun 20, 2021

Conversation

fauxpark
Copy link
Member

Description

Just clearing out my stashes. Could be converted to custom matrix lite - may try that at some point later.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 17, 2021 08:01
drashna
drashna approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Though, yeah, would prefer if it was converted to matrix lite, which shouldn't be too much work.

https://docs.qmk.fm/#/custom_matrix?id=lite

@fauxpark
Copy link
Member Author

Here's an attempt. I don't have hardware to test, and not sure how to calculate the return value properly, but it compiles.

@drashna drashna requested a review from a team June 18, 2021 04:27
@drashna
Copy link
Member

drashna commented Jun 18, 2021

Yeah, that looks right, for the matrix!

@fauxpark fauxpark merged commit 4dddcb4 into qmk:master Jun 20, 2021
@fauxpark fauxpark deleted the telophase-cleanup branch June 20, 2021 02:03
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@fauxpark @HokieGeek
Telophase cleanup (qmk#13225)
c215a46
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@fauxpark @wox
Telophase cleanup (qmk#13225)
5ea3edf
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Telophase cleanup (qmk#13225)
d44818b
@fauxpark fauxpark mentioned this pull request Dec 16, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna