Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API_SYSEX_ENABLEs from rules.mk #13389

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Remove API_SYSEX_ENABLEs from rules.mk #13389

merged 1 commit into from
Jul 1, 2021

Conversation

fauxpark
Copy link
Member

Description

XAP will likely obsolete this feature that nobody uses anyway. For the boards which had it enabled:

9key
hadron/ver2
m10a
ncc1701kb
themadnoodle/ncc1701kb/v2
themadnoodle/noodlepad

I could find no related code that would warrant it, so it seems safe to remove.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 30, 2021 01:01
@tzarc tzarc requested a review from a team June 30, 2021 01:23
@drashna drashna merged commit 44260c3 into qmk:develop Jul 1, 2021
@fauxpark fauxpark deleted the api-sysex-remove-rules branch July 1, 2021 06:41
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Remove API_SYSEX_ENABLEs from rules.mk (qmk#13389)
65de277
@daskygit daskygit mentioned this pull request Jan 13, 2022
Merged
14 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Remove API_SYSEX_ENABLEs from rules.mk (qmk#13389)
d7eeace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nooges nooges nooges approved these changes

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @nooges @drashna @tzarc