Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ellora65 #14754

Merged
merged 14 commits into from
Feb 21, 2022
Merged

Ellora65 #14754

merged 14 commits into from
Feb 21, 2022

Conversation

swiftrax
Copy link
Contributor

@swiftrax swiftrax commented Oct 8, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 8, 2021
@swiftrax swiftrax mentioned this pull request Oct 8, 2021
Closed
6 tasks
zvecr
zvecr requested changes Oct 8, 2021
View reviewed changes
keyboards/kikoslab/ellora65/config.h Outdated Show resolved Hide resolved
keyboards/kikoslab/ellora65/info.json Outdated Show resolved Hide resolved
keyboards/kikoslab/ellora65/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/kikoslab/ellora65/keymaps/via/rules.mk Outdated Show resolved Hide resolved
drashna
drashna requested changes Oct 11, 2021
View reviewed changes
keyboards/kikoslab/ellora65/rules.mk Outdated Show resolved Hide resolved
keyboards/kikoslab/ellora65/rules.mk Outdated Show resolved Hide resolved
@swiftrax @drashna
Apply suggestions from code review
72ca022 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team October 11, 2021 05:15
fauxpark
fauxpark requested changes Oct 11, 2021
View reviewed changes
keyboards/kikoslab/ellora65/info.json Outdated Show resolved Hide resolved
@swiftrax @fauxpark
Update keyboards/kikoslab/ellora65/info.json
920ebcd 
Co-authored-by: Ryan <fauxpark@gmail.com>
drashna
drashna requested changes Jan 7, 2022
View reviewed changes
keyboards/kikoslab/ellora65/rules.mk Outdated Show resolved Hide resolved
@swiftrax @drashna
Update keyboards/kikoslab/ellora65/rules.mk
65fa9a9 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@swiftrax swiftrax requested a review from drashna January 7, 2022 20:14
fauxpark
fauxpark requested changes Jan 10, 2022
View reviewed changes
keyboards/kikoslab/ellora65/rules.mk Outdated Show resolved Hide resolved
@swiftrax @fauxpark
Update keyboards/kikoslab/ellora65/rules.mk
66c49b2 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit 67b9a72 into qmk:master Feb 21, 2022
@drashna
Copy link
Member

drashna commented Feb 21, 2022

Thanks!

@waffle87 waffle87 mentioned this pull request Feb 21, 2022
Merged
9 tasks
@swiftrax swiftrax mentioned this pull request Feb 21, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprof sigprof sigprof left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@swiftrax @drashna @sigprof @fauxpark @zvecr