Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customMK EVO70 #14907

Merged
merged 26 commits into from
Jul 19, 2022
Merged

Add customMK EVO70 #14907

merged 26 commits into from
Jul 19, 2022

Conversation

infinityis
Copy link
Contributor

@infinityis infinityis commented Oct 22, 2021 •
edited
Loading

Description

Adding keyboard and keymap files for customMK EVO70

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 22, 2021
@infinityis infinityis mentioned this pull request Oct 22, 2021
Closed
6 tasks
zvecr
zvecr requested changes Oct 22, 2021
View reviewed changes
keyboards/custommk/evo70/rules.mk Outdated Show resolved Hide resolved
keyboards/custommk/evo70/evo70.c Outdated Show resolved Hide resolved
keyboards/custommk/evo70/evo70.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 8, 2022 03:53
fauxpark
fauxpark requested changes Mar 8, 2022
View reviewed changes
keyboards/custommk/evo70/rules.mk Outdated Show resolved Hide resolved
keyboards/custommk/evo70/config.h Outdated Show resolved Hide resolved
infinityis and others added 2 commits March 7, 2022 22:12
@infinityis @fauxpark
Update keyboards/custommk/evo70/rules.mk
f6ce5cd 
Co-authored-by: Ryan <fauxpark@gmail.com>
@infinityis @fauxpark
Update keyboards/custommk/evo70/config.h
5fbefd0 
Co-authored-by: Ryan <fauxpark@gmail.com>
@infinityis infinityis requested a review from fauxpark March 8, 2022 04:14
fauxpark
fauxpark requested changes Mar 18, 2022
View reviewed changes
keyboards/custommk/evo70/info.json Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team April 13, 2022 05:28
@stale
Copy link

stale bot commented Jun 12, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

noroadsleft
noroadsleft requested changes Jul 16, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/custommk/evo70/evo70.h Outdated Show resolved Hide resolved
keyboards/custommk/evo70/info.json Outdated Show resolved Hide resolved
keyboards/custommk/evo70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/custommk/evo70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/custommk/evo70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/custommk/evo70/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/custommk/evo70/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/custommk/evo70/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/custommk/evo70/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/custommk/evo70/readme.md Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Jul 17, 2022
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this last change for me, and if fauxpark becomes satisfied with the encoder implementation, I'm good with this being merged after this change.

keyboards/custommk/evo70/readme.md Outdated Show resolved Hide resolved
@infinityis infinityis requested a review from fauxpark July 17, 2022 17:32
@noroadsleft noroadsleft merged commit 1bf95d6 into qmk:master Jul 19, 2022
@noroadsleft
Copy link
Member

Thanks!

@infinityis infinityis mentioned this pull request Jul 19, 2022
Merged
6 tasks
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
@infinityis @smocky
[Keyboard] customMK EVO70 (qmk#14907)
cb6d15c 
* added files for EVO70

* updated info.json and readme

* ran qmk lint and fixed typo in info.json

* removed defines from config.h in favor of info.json

* removed an unnecssary include

* removed unnecessary code

* updated rules.mk to remove mention of Bluetooth

* corrected edit to rules.mk

* added code for OLED menu display

* removed extraneous comments and spaces

* added bongo cat animation

* Update keyboards/custommk/evo70/rules.mk

* Update keyboards/custommk/evo70/config.h

* Modified Bongocat graphics to match original proportions

* updated info.json device version

* updated OLED splash screen display timing

* improved bongo cat tap detection and added backlight breathing to OLED menu

* various improvements to OLED, saving settings, and VIA keymap fix

* removed extraneous define

* custom encoder assignment retained upon powerup, backlight sleep upon suspend

* corrected bongo cat tap detection

* Changed splash screen and bongo cat encoder rotation to use the custom assignments

* removed _default from LAYOUT naming and changed keyboard image to be hosted from imgur

* Force smaller version of image to be used in readme
Haruki pushed a commit to Haruki/qmk_firmware that referenced this pull request Jul 23, 2022
@infinityis @Haruki
[Keyboard] customMK EVO70 (qmk#14907)
e475026 
* added files for EVO70

* updated info.json and readme

* ran qmk lint and fixed typo in info.json

* removed defines from config.h in favor of info.json

* removed an unnecssary include

* removed unnecessary code

* updated rules.mk to remove mention of Bluetooth

* corrected edit to rules.mk

* added code for OLED menu display

* removed extraneous comments and spaces

* added bongo cat animation

* Update keyboards/custommk/evo70/rules.mk

* Update keyboards/custommk/evo70/config.h

* Modified Bongocat graphics to match original proportions

* updated info.json device version

* updated OLED splash screen display timing

* improved bongo cat tap detection and added backlight breathing to OLED menu

* various improvements to OLED, saving settings, and VIA keymap fix

* removed extraneous define

* custom encoder assignment retained upon powerup, backlight sleep upon suspend

* corrected bongo cat tap detection

* Changed splash screen and bongo cat encoder rotation to use the custom assignments

* removed _default from LAYOUT naming and changed keyboard image to be hosted from imgur

* Force smaller version of image to be used in readme
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@infinityis @schattenbrot
[Keyboard] customMK EVO70 (qmk#14907)
49bd0f1 
* added files for EVO70

* updated info.json and readme

* ran qmk lint and fixed typo in info.json

* removed defines from config.h in favor of info.json

* removed an unnecssary include

* removed unnecessary code

* updated rules.mk to remove mention of Bluetooth

* corrected edit to rules.mk

* added code for OLED menu display

* removed extraneous comments and spaces

* added bongo cat animation

* Update keyboards/custommk/evo70/rules.mk

* Update keyboards/custommk/evo70/config.h

* Modified Bongocat graphics to match original proportions

* updated info.json device version

* updated OLED splash screen display timing

* improved bongo cat tap detection and added backlight breathing to OLED menu

* various improvements to OLED, saving settings, and VIA keymap fix

* removed extraneous define

* custom encoder assignment retained upon powerup, backlight sleep upon suspend

* corrected bongo cat tap detection

* Changed splash screen and bongo cat encoder rotation to use the custom assignments

* removed _default from LAYOUT naming and changed keyboard image to be hosted from imgur

* Force smaller version of image to be used in readme
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@infinityis @imhoffman
[Keyboard] customMK EVO70 (qmk#14907)
214bfd4 
* added files for EVO70

* updated info.json and readme

* ran qmk lint and fixed typo in info.json

* removed defines from config.h in favor of info.json

* removed an unnecssary include

* removed unnecessary code

* updated rules.mk to remove mention of Bluetooth

* corrected edit to rules.mk

* added code for OLED menu display

* removed extraneous comments and spaces

* added bongo cat animation

* Update keyboards/custommk/evo70/rules.mk

* Update keyboards/custommk/evo70/config.h

* Modified Bongocat graphics to match original proportions

* updated info.json device version

* updated OLED splash screen display timing

* improved bongo cat tap detection and added backlight breathing to OLED menu

* various improvements to OLED, saving settings, and VIA keymap fix

* removed extraneous define

* custom encoder assignment retained upon powerup, backlight sleep upon suspend

* corrected bongo cat tap detection

* Changed splash screen and bongo cat encoder rotation to use the custom assignments

* removed _default from LAYOUT naming and changed keyboard image to be hosted from imgur

* Force smaller version of image to be used in readme
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@infinityis @nolanseaton
[Keyboard] customMK EVO70 (qmk#14907)
e8289fe 
* added files for EVO70

* updated info.json and readme

* ran qmk lint and fixed typo in info.json

* removed defines from config.h in favor of info.json

* removed an unnecssary include

* removed unnecessary code

* updated rules.mk to remove mention of Bluetooth

* corrected edit to rules.mk

* added code for OLED menu display

* removed extraneous comments and spaces

* added bongo cat animation

* Update keyboards/custommk/evo70/rules.mk

* Update keyboards/custommk/evo70/config.h

* Modified Bongocat graphics to match original proportions

* updated info.json device version

* updated OLED splash screen display timing

* improved bongo cat tap detection and added backlight breathing to OLED menu

* various improvements to OLED, saving settings, and VIA keymap fix

* removed extraneous define

* custom encoder assignment retained upon powerup, backlight sleep upon suspend

* corrected bongo cat tap detection

* Changed splash screen and bongo cat encoder rotation to use the custom assignments

* removed _default from LAYOUT naming and changed keyboard image to be hosted from imgur

* Force smaller version of image to be used in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
awaiting changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@infinityis @noroadsleft @drashna @fauxpark @zvecr