Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update updated KPrepublic boards to be prepared for the update #15040

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Nov 3, 2021

I added a /rev1 directory to

  • bm60rgb
  • bm60rgb_iso
  • bm60poker

, as KPrepublic has updated the boards with a v2 (see discussion here #14800). This prepares these boards to be able to have a /rev2 directory added, without being a breaking change.

bm65rgb is already updated with a /rev1 in #14800

Please inform me of any other v2 boards they have made so I can update this list

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@peepeetee
Copy link
Contributor Author

from @sigprof in #14800 :

Not really sure what the purpose of the rev folders are.

KPrepublic silently updated the boards sold at kprepublic.com/products/bm65rgb-bm65-rgb-65-hot-swappable-custom-mechanical-keyboard-pcb-programmed-qmk-via-firmware-full-rgb-switch-underglow-type-c (and other their shops) from the original PCB revision (both per-key RGB LEDs and underglow LEDs implemented as a single chain of WS2812-like addressable LEDs) to the new one called “BM65V2” (per-key RGB LEDs using IS31FL3741, underglow using WS2812, different pins used for key matrix). The intent is to add support for older boards as kprepublic/bm65rgb/rev1, and then add the new version as kprepublic/bm65rgb/rev2; this way the keymaps may be shared between both versions of the PCB (the layout is exactly the same).

However, if this PR is intended to add the support just for the older BM65RGB PCB, it should contain only the kprepublic/bm65rgb/rev1 files, and no rev2 files at all — rev2 could be added later.

@peepeetee
Copy link
Contributor Author

@bytesapart @markva @mechmerlin @ipetepete

@tzarc
Copy link
Member

tzarc commented Nov 5, 2021

Just a note for other collaborators: this missed the deadline for the Nov'21 breaking changes -- it's preferable that this goes in earlier rather than later, so I'm marking it to be included.

@tzarc tzarc requested a review from a team November 5, 2021 03:38
@drashna drashna requested a review from a team November 5, 2021 16:01
@drashna drashna merged commit 7562c5b into qmk:develop Nov 5, 2021
sigprof added a commit to sigprof/qmk_firmware that referenced this pull request Nov 6, 2021
Rename keyboard files after moving them into revision directories.
@peepeetee peepeetee mentioned this pull request Nov 6, 2021
14 tasks
zvecr pushed a commit that referenced this pull request Nov 6, 2021
Rename keyboard files after moving them into revision directories.
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Nov 10, 2021
* qmk/develop: (100 commits)
  [Keyboard] Fix compilation issues for teleport numpad (qmk#15110)
  [Keyboard] Add Paroxysm keyboard to Cradio (qmk#15097)
  [Keyboard] Update mb44.h (qmk#15092)
  [Keyboard] Stream cheap via fixes/updates (qmk#14325)
  [Keyboard] PK64RGB Keyboard Addition (qmk#14627)
  [Keyboard] Element Hotswap PCB (qmk#15082)
  [Keyboard] Teleport numpad (qmk#14905)
  Updates to drashna keymap and minor updates to tractyl manuform (qmk#15101)
  Update noroadsleft userspace and keymaps (2021-11-09) (qmk#15099)
  Mechlovin Pisces Refactor (qmk#15080)
  idb 60 Layout Macro Refactor (qmk#15079)
  [Keyboard] Add new keyboard "Heavy Left" (qmk#15052)
  Fixup broken build after qmk#15040 (qmk#15073)
  [Keyboard] Add VIA to Gud70 (qmk#15071)
  [Keyboard] Fix compilation issues for superuser tkl (qmk#15070)
  [Keyboard] Add Ziggurat keyboard (qmk#15008)
  Update updated KPrepublic boards to be prepared for the update (qmk#15040)
  [Keymap] add keymap for xd60 (qmk#15053)
  [Keymap] Revamp the ergodox french_hacker layout (qmk#15064)
  kprepublic/bm65rgb/rev1: Fix info.json (qmk#15066)
  ...
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants