Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short term bodge for PRODUCT warning #15240

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 20, 2021

Description

With code freeze looming, virtually every keyboard is spitting out the following warning

make zvecr/zv48:default:flash
QMK Firmware 0.14.31
⚠ zvecr/zv48/f401: PRODUCT in config.h is overwriting keyboard_name in info.json
Making zvecr/zv48/f401 with keymap default and target flash

⚠ zvecr/zv48/f401: PRODUCT in config.h is overwriting keyboard_name in info.json
arm-none-eabi-gcc (Arch Repository) 11.2.0

While maybe a better experience while porting new keyboards, this is just going to cause issues for the majority. (Just look at how many questions get raised about the arm size warning)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team November 20, 2021 20:44
@zvecr zvecr added the bug label Nov 20, 2021
@zvecr zvecr merged commit eeab6f1 into qmk:develop Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants