Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Hotfix for HOLD_ON_OTHER_KEY_PRESS after #11059 #15307

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Nov 26, 2021

#11059 broke compilation with keyboards that have HOLD_ON_OTHER_KEY_PRESS because of a typo: KEYPRESS should have been KEY_PRESS.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Nov 26, 2021
quantum/action_tapping.c Outdated Show resolved Hide resolved
@KarlK90
Copy link
Member Author

KarlK90 commented Nov 26, 2021

Thanks @sigprof I rushed that and I agree that it should be added to the tests. Is this something that you would want to do?

that broke compilation because of a typo: KEYPRESS should have been
KEY_PRESS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants