Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing virtser_init() to ChibiOS code #15356

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

fauxpark
Copy link
Member

Description

If Steno/Virtser is enabled on a ChibiOS board, you get a linker error on virtser_init() as it is called in keyboard.c but only implemented in lufa.c.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 30, 2021 05:39
@tzarc tzarc merged commit ed49dbe into qmk:master Nov 30, 2021
@fauxpark fauxpark deleted the virtser-init branch November 30, 2021 05:59
rudism pushed a commit to rudism/qmk_firmware that referenced this pull request Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants