[Keyboard] support for Stack Overflow The Key from Drop - adapted from @frap129 #15520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Dec 20, 2021
there's still some issues related to LEDs so i think for now the best course of action is to remove those items until we can get better details on the assembly of the board.
tzarc
requested changes
Dec 20, 2021
There was a problem hiding this comment.
You'll also want to go through the PR checklist which has notes like requiring a standard template for the readme.md and what we're looking for content-wise.
keyboards/massdrop/thekey/keymaps/url-copy-paste-macos/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/massdrop/thekey/keymaps/url-copy-paste-macos/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/massdrop/thekey/keymaps/url-copy-paste-macos/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/massdrop/thekey/readme.md
Outdated
Comment on lines
32
to
34
| [Massdrop Loader Releases](https://github.com/Massdrop/mdloader/releases/tag/1.0.3) | ||
| [Massdrop Loader Repository and Instructions](https://github.com/Massdrop/mdloader)[Massdrop Loader Releases] | ||
| [Massdrop Loader Repository and Instructions] |
There was a problem hiding this comment.
mdloader is for their ATSAMD-based boards, i.e. their CTRL/ALT etc. -- it doesn't function with AVR 32U4-based boards.
You'll want to grab the same wording from another 32U4-based board in the repo, here.
There was a problem hiding this comment.
yea, this was my bad trying to fix something while someone else was talking to me. they don't actually have this information on their repos, just buried in the forums. it's probably best to remove it and just leave the verified instructions i have above.
tzarc
reviewed
Dec 20, 2021
fauxpark
requested changes
Dec 21, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
tzarc
approved these changes
Dec 21, 2021
fauxpark
approved these changes
Dec 22, 2021
ryphon
pushed a commit
to ryphon/qmk_firmware
that referenced
this pull request
Jan 12, 2022
…@frap129 (qmk#15520) * support for Stack Overflow The Key from Drop - adapted from @frap129 * addressing code review comments there's still some issues related to LEDs so i think for now the best course of action is to remove those items until we can get better details on the assembly of the board. * removing this on the correct branch * cleaning up more code review comments, moving to simpler/common formats for maps * it is a C not a G fool * well, looks like you can do it this way too for booting/dfu * fixing missing newline for gcc to be quiet * removing busted links * formatting to match current template * Update keyboards/massdrop/thekey/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Andy Piper <andypiper@users.noreply.github.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes from @andypiper based on @frap129. Includes the default configuration as well as the other macro based items. Tested on 3 keyboards and found to be functional. Apologies to @andypiper on this if they were planning on making the PR, I just didn't want it to go stale.
Types of Changes
Issues Fixed or Closed by This PR
Checklist