Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "No C files in filelist: None" #15560

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 23, 2021

Description

Noticed on 15555 that the formatters did not correctly kick in https://github.com/qmk/qmk_firmware/runs/4608117091?check_suite_focus=true.

Fixes the following issues:

  1. core/ignore path comparison getting mixed up with absolute and relative paths
  2. cli.args.files was being modified which caused the filtered filenames to later be printed as None

The behaviour can be tested locally with:

qmk format-c --core-only quantum/quantum.c

A valid core file, yet formatting fails.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Dec 23, 2021
@zvecr zvecr requested review from a team December 23, 2021 17:49
@github-actions github-actions bot added cli qmk cli command python labels Dec 23, 2021
@zvecr zvecr force-pushed the feature/fix_format_absolutes branch from dd02938 to a705463 Compare December 23, 2021 19:00
@zvecr zvecr merged commit aea7155 into qmk:master Jan 3, 2022
maherma-adg pushed a commit to maherma-adg/qmk_firmware that referenced this pull request Jan 4, 2022
* Fix "No C files in filelist: None"

* Align other commands

* force absolute paths
ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022
* Fix "No C files in filelist: None"

* Align other commands

* force absolute paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants