Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] New Keyboard - BDE Rev2 #15877

Merged
merged 14 commits into from
Mar 4, 2022
Merged

[Keyboard] New Keyboard - BDE Rev2 #15877

merged 14 commits into from
Mar 4, 2022

Conversation

kylemccreery
Copy link
Contributor

Description

Initial PR for adding the BDE Rev2 keyboard kit by MechWild. This is the default and VIA keymaps. Additionally, I reorganized the original BDE folder for easier building and maintaining legacy version support (Rev1)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 14, 2022
@kylemccreery
Copy link
Contributor Author

@drashna Thanks for the clarification. Fixed.

@kylemccreery @drashna
Update keyboards/mechwild/bde/rules.mk
5955089 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@kylemccreery
Copy link
Contributor Author

@drashna Should a review be requested from qmk/collaborators now?

@drashna drashna requested a review from a team February 7, 2022 18:23
fauxpark
fauxpark requested changes Feb 8, 2022
View reviewed changes
keyboards/mechwild/bde/rules.mk Outdated Show resolved Hide resolved
keyboards/mechwild/bde/rules.mk Outdated Show resolved Hide resolved
@kylemccreery @fauxpark
Apply suggestions from code review
33dee21 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kylemccreery
Copy link
Contributor Author

@fauxpark is there another change that needs to be made?

fauxpark
fauxpark requested changes Feb 21, 2022
View reviewed changes
keyboards/mechwild/bde/rules.mk Outdated Show resolved Hide resolved
@kylemccreery @fauxpark
Update keyboards/mechwild/bde/rules.mk
dc0a7c7 
Co-authored-by: Ryan <fauxpark@gmail.com>
@kylemccreery
Copy link
Contributor Author

@fauxpark is this just waiting on merging at this point?

@drashna drashna merged commit 0be7345 into qmk:master Mar 4, 2022
@drashna
Copy link
Member

drashna commented Mar 4, 2022

Thanks!

@kylemccreery kylemccreery mentioned this pull request Mar 5, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylemccreery @drashna @fauxpark