Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mitosis-mjt audio #1653

Merged
merged 39 commits into from
Aug 30, 2017
Merged

Fixed mitosis-mjt audio #1653

merged 39 commits into from
Aug 30, 2017

Conversation

mterhar
Copy link
Contributor

@mterhar mterhar commented Aug 28, 2017

Some audio options needed to be adjusted.

mterhar added 30 commits July 6, 2017 11:21
…e to the matrix being directly put into the array rather than using the keymap function.
Enabled dynamic macros and moved
somoe of the shortcuts around.
Bring over recent QMK updates
Bring over recent QMK updates
@mterhar
Copy link
Contributor Author

mterhar commented Aug 28, 2017

What is the best way to warn users to not enable audio with MouseKeys? It doesn't make a particularly big firmware but it's big enough to brick a promicro.

I'm asking because the "rules.mk" file change here includes my disabling and enabling things to make the firmware flashing safe. I've screwed up 3 promicros futzing with this to try to avr-isp bootloader them (desoldering them poorly causing pads and traces to fall off).

I'm going to commit another one with the rules.mk in the parent reverted. If the makefile in my keymap folder is sufficient to override the rules.mk, I'll just add a warning comment in there.

@mterhar
Copy link
Contributor Author

mterhar commented Aug 29, 2017

Cleaned up rules.mk so this commit is limited to just my mitosis layout.

@jackhumbert
Copy link
Member

Perfect! Thanks for updating :)

@jackhumbert jackhumbert merged commit a4316ba into qmk:master Aug 30, 2017
akatrevorjay added a commit to akatrevorjay/qmk_firmware that referenced this pull request Sep 1, 2017
* 'master' of git://github.com/qmk/qmk_firmware: (30 commits)
  Set proper backlight level
  convert to unix line-endings [skip ci]
  Alterations and documentation updates for j3rn Ergodox EZ keymap (qmk#1656)
  Port qmk#1576 to Let's Split: EECONFIG_HANDEDNESS gets overridden when RGB is enabled
  rask's Satan and BananaSplit60 (qmk#1654)
  Fixed mitosis-mjt audio (qmk#1653)
  add UC_OSX_RALT to make unicode use the Right Alt key on OSX
  Update drashna's keymap  (qmk#1649)
  Update README.
  Small gaming layer and formatting updates to my nyquist config.
  Add the new QMK submodule way in `/lib` and not `tmk_core/tool` wich is outdated
  add a `git-submodule` make target.
  add rule shortcut via @samwho's suggesion
  add bin targets - closes qmk#1648, fixes qmk#1647
  Keymaps for several of my boards (qmk#1641)
  make ergodone's led work well
  Updated readme to new standard.
  Updated my files and added debouncing
  Add mbsurfer Let's Split keymap with RGB layer indicators (qmk#1638)
  Merge in gaming layout.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants