qmk.path.FileType: fix argument handling #16693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Mar 19, 2022
zvecr
approved these changes
Mar 19, 2022
fauxpark
changed the title
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
* qmk.path.FileType: pass in mode as first argument * Better solution * Grammar...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the mode string passed to
qmk.path.FileTypeis mistakenly given to theencodingargument of the superclass if it is not explicitly named (eg.qmk.path.FileType('r')).Types of Changes
Issues Fixed or Closed by This PR
Checklist