Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emulated eeprom support for STM32F303xE #16737

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

dn9uyen
Copy link

@dn9uyen dn9uyen commented Mar 27, 2022

Description

Added STM32F303xE to FEE_PAGE_SIZE and FEE_MCU_FLASH_SIZE defines in platforms/ChibiOS/eeprom_stm32_defs.h

QMK currently assumes mcus to be STM32F303xC for MCU = STM32F303. In order to compile for STM32F303xE, it was necessary to include a board.h as explained in #8179 (comment). However, that solution no longer works so this PR fixes it.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Added FEE_PAGE_SIZE and FEE_MCU_FLASH_SIZE defines for the STM32F303xE
@github-actions github-actions bot added the core label Mar 27, 2022
@drashna drashna requested a review from a team March 29, 2022 02:37
@zvecr zvecr changed the title Fix support for the STM32F303xE Add emulated eeprom support for STM32F303xE Mar 30, 2022
@zvecr zvecr merged commit 38209c5 into qmk:develop Mar 30, 2022
@dn9uyen dn9uyen deleted the STM32F303xE_support branch March 30, 2022 21:21
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Added FEE_PAGE_SIZE and FEE_MCU_FLASH_SIZE defines for the STM32F303xE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants