Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for easy Windows environment setup #170

Merged
merged 8 commits into from
Mar 4, 2016

Conversation

NoahAndrews
Copy link
Contributor

Currently tested on Windows 10, 64-bit.

@NoahAndrews
Copy link
Contributor Author

The reason I recommend the MHV AVR tools instead of the official ones is that they're much easier to obtain. With the official ones, you have to give them your email address and have a link emailed to you. The MHV AVR Tools work perfectly even on the latest version of Windows, and even allow for redistribution if we want to go that route.

@ezuk
Copy link
Contributor

ezuk commented Mar 3, 2016

This looks good to me! Perhaps consider moving the readme to something like the QUICK-START.md in the root? Maybe we can refactor that file, change it to "build_instructions.md" and include both your doc and the existing content?

@NoahAndrews
Copy link
Contributor Author

I couldn’t agree more that files need to be shuffled around, and that’s what I’m going to work on next. I’m thinking about renaming the quick start file to VAGRANT-SETUP.md.

On Mar 2, 2016, at 8:12 PM, Erez Zukerman notifications@github.com wrote:

This looks good to me! Perhaps consider moving the readme to something like the QUICK-START.md in the root? Maybe we can refactor that file, change it to "build_instructions.md" and include both your doc and the existing content?


Reply to this email directly or view it on GitHub #170 (comment).

@ezuk
Copy link
Contributor

ezuk commented Mar 3, 2016

It would be cool if there was just a single build document, split up into
various OSes and what you need to do to get set up with each. What do you
think? Happy to collaborate on something like that.

On 2 March 2016 at 13:03, Noah Andrews notifications@github.com wrote:

Currently tested on Windows 10, 64-bit.

You can view, comment on, or merge this pull request online at:

#170
Commit Summary

  • Add script to setup the PATH variable on Windows
  • Include MSYS directory in Windows path
  • Added Windows environment setup script
  • Removed unneeded lines from setup script
  • Added logging to setup script
  • Renamed scripts to show order
  • Added documentation for new Windows scripts

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#170.

@NoahAndrews
Copy link
Contributor Author

Agreed! And that should go in the root, not in the Planck folder.

@ezuk
Copy link
Contributor

ezuk commented Mar 3, 2016

Totally. And be linked from the main project readme. Wanna get it started?

On 2 March 2016 at 20:23, Noah Andrews notifications@github.com wrote:

Agreed! And that should go in the root, not in the Planck folder.


Reply to this email directly or view it on GitHub
#170 (comment)
.

@NoahAndrews
Copy link
Contributor Author

You make the Ergodox EZ, right? Does that disqualify you from this? :P

@NoahAndrews
Copy link
Contributor Author

When I get home from this robotics meeting, yeah!

@ezuk
Copy link
Contributor

ezuk commented Mar 3, 2016

Hahaha, yeah, I make the ErgoDox EZ :) What I say in the video is the truth
-- I'm really not into soldering, I just bought my Planck all assembled
from @jackhumbert. :)

On 2 March 2016 at 20:30, Noah Andrews notifications@github.com wrote:

When I get home from this robotics meeting, yeah!


Reply to this email directly or view it on GitHub
#170 (comment)
.

@NoahAndrews
Copy link
Contributor Author

I've created a separate pull request for the restructuring #171

@NoahAndrews
Copy link
Contributor Author

Have you actually tested my new build instructions and script? It would be good to have confirmation that it works somewhere other than my test VM.

@NoahAndrews
Copy link
Contributor Author

I've added you as a contributor to my fork so that you can contribute to that branch.

@jackhumbert
Copy link
Member

This is great! :)

jackhumbert added a commit that referenced this pull request Mar 4, 2016
Add scripts for easy Windows environment setup
@jackhumbert jackhumbert merged commit 3f7180a into qmk:master Mar 4, 2016
@NoahAndrews NoahAndrews deleted the improve-windows-docs branch March 21, 2016 15:22
Jpe230 pushed a commit to Jpe230/qmk_firmware that referenced this pull request Dec 15, 2021
* Add Keychron K8 optical

* Add readme, add optical and optical_via variants

* Minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants