Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alicekk support #17027

Merged
merged 12 commits into from
Jul 2, 2022
Merged

Add alicekk support #17027

merged 12 commits into from
Jul 2, 2022

Conversation

TW59420
Copy link
Contributor

@TW59420 TW59420 commented May 7, 2022

Description

MWStudio is a custom keyboard enthusiast
Upload qmk firmware of alicekk series PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 7, 2022
@TW59420 TW59420 closed this May 7, 2022
@TW59420 TW59420 reopened this May 7, 2022
drashna
drashna requested changes May 11, 2022
View reviewed changes
keyboards/mwstudio/alicekk/rules.mk Outdated Show resolved Hide resolved
keyboards/mwstudio/alicekk/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team May 11, 2022 11:03
fauxpark
fauxpark requested changes May 11, 2022
View reviewed changes
keyboards/mwstudio/alicekk/readme.md Outdated Show resolved Hide resolved
TW59420 and others added 3 commits May 12, 2022 14:55
@TW59420 @drashna
Update keyboards/mwstudio/alicekk/rules.mk
7a32b23 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@TW59420 @fauxpark
Update keyboards/mwstudio/alicekk/readme.md
905f375 
Co-authored-by: Ryan <fauxpark@gmail.com>
@TW59420 @drashna
Update keyboards/mwstudio/alicekk/rules.mk
95110b8 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@TW59420 TW59420 requested review from fauxpark and drashna May 12, 2022 06:56
drashna
drashna requested changes May 13, 2022
View reviewed changes
keyboards/mwstudio/alicekk/config.h Outdated Show resolved Hide resolved
keyboards/mwstudio/alicekk/alicekk.c Show resolved Hide resolved
keyboards/mwstudio/alicekk/keymaps/via/keymap.c Outdated Show resolved Hide resolved
TW59420 and others added 6 commits May 14, 2022 13:55
@TW59420 @drashna
Update keyboards/mwstudio/alicekk/keymaps/via/keymap.c
ad9bb6f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@TW59420 @drashna
Update keyboards/mwstudio/alicekk/alicekk.c
604a8ef 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@TW59420 @drashna
Update keyboards/mwstudio/alicekk/config.h
826798d 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@TW59420
Update keymap.c
7b261b4
@TW59420
Update keymap.c
a7260db
@TW59420
Update alicekk.h
1a006b6
@TW59420 TW59420 requested a review from drashna May 14, 2022 06:01
@TW59420 @drashna
Update keyboards/mwstudio/alicekk/config.h
e405109 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@TW59420 TW59420 requested a review from drashna May 17, 2022 13:58
@drashna drashna requested a review from a team May 20, 2022 05:06
@zvecr zvecr merged commit f2d4424 into qmk:master Jul 2, 2022
@TW59420 TW59420 mentioned this pull request Jul 4, 2022
Merged
6 tasks
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@TW59420 @schattenbrot
Add alicekk support (qmk#17027)
91d324f
@TW59420 TW59420 deleted the alicekk branch December 2, 2022 11:15
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@TW59420 @nolanseaton
Add alicekk support (qmk#17027)
ca64c1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TW59420 @drashna @fauxpark @zvecr