Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] TR90PM #17060

Merged
merged 6 commits into from
Jul 11, 2022
Merged

[Keyboard] TR90PM #17060

merged 6 commits into from
Jul 11, 2022

Conversation

balloondogcaps
Copy link

@balloondogcaps balloondogcaps commented May 11, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • This PR adds support for the TR90PM

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 11, 2022
balloondogcaps and others added 2 commits May 11, 2022 16:05
@balloondogcaps @zvecr
Update keyboards/balloondogcaps/tr90pm/keymaps/via/keymap.c
327e376 
Co-authored-by: Joel Challis <git@zvecr.com>
@balloondogcaps @zvecr
Update keyboards/balloondogcaps/tr90pm/rules.mk
e2c487e 
Co-authored-by: Joel Challis <git@zvecr.com>
@balloondogcaps balloondogcaps requested a review from zvecr May 11, 2022 14:10
@balloondogcaps @drashna
Update keyboards/balloondogcaps/tr90pm/readme.md
8e70081 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team May 12, 2022 01:06
fauxpark
fauxpark requested changes May 12, 2022
View reviewed changes
keyboards/balloondogcaps/tr90pm/info.json Outdated Show resolved Hide resolved
keyboards/balloondogcaps/tr90pm/config.h Outdated Show resolved Hide resolved
@balloondogcaps
Copy link
Author

Hey @fauxpark and @zvecr , I usually don't bump but can you give me some insights on the review schedule? It has almost been 2 months since the original PR.

@drashna drashna merged commit 61a5059 into qmk:master Jul 11, 2022
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
@balloondogcaps @zvecr
@drashna @fauxpark @smocky
[Keyboard] TR90PM (qmk#17060)
9604be9 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@balloondogcaps @zvecr
@drashna @fauxpark @schattenbrot
[Keyboard] TR90PM (qmk#17060)
ae6aac9 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@balloondogcaps @zvecr
@drashna @fauxpark @imhoffman
[Keyboard] TR90PM (qmk#17060)
cfa42ee 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@balloondogcaps @zvecr
@drashna @fauxpark @nolanseaton
[Keyboard] TR90PM (qmk#17060)
d35707b 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balloondogcaps @drashna @fauxpark @zvecr