Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-ify Send String #17275

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Feature-ify Send String #17275

merged 2 commits into from
Jul 2, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented May 31, 2022

Description

Doesn't really affect filesize if disabled, as the compiler is smart enough to optimise it out, but it's worth making these things more modular and self-contained... and maybe shaves off a nanosecond or two in compilation 😛

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 31, 2022 19:10
@tzarc tzarc merged commit 3ecb0a8 into qmk:develop Jul 2, 2022
@fauxpark fauxpark deleted the send-string-feature branch July 2, 2022 12:12
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants