Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keymap] Update gourdo1 keymap for Q2 changes #17398

Merged
merged 21 commits into from
Jul 2, 2022
Merged

Conversation

gourdo1
Copy link

@gourdo1 gourdo1 commented Jun 16, 2022

Description

A number of updates to the gourdo1 keymap (GMMK Pro), including:

  • ISO layout (added June 29, 2022)
  • added several EEPROM persistent toggle-able features (added June 29, 2022)
  • replacing my custom Capsword implementation with QMK's new built-in functionality
  • customizing Capsword symbol overrides
  • disabling many redundant RGB background effects with undef statements
  • incorporation of Tomas Guinan's paddle game
  • a number of tweaks to the keymap (primarily FN1 layer)
  • updated contact information in license blurbs
  • removal of some unreferenced code snippets
  • fix for breaking changes to GMMK Pro encoder
  • a few cosmetic fixes/tweaks
  • updated readme.md

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team June 16, 2022 18:19
* first commit (broken compile)

* initial working prototype

* added numpad rgb toggle

* minor update to toggles

* fixed double tap shift for caps toggle

* custom capslock tapdance; esc layer custom tapdance (broken)

* ESC double tap test

* cleanup obsolete code

* license notices and cosmetics

* Implemented Home/Del key swap toggle

* breakout custom double taps into separate H file.

* partial fix for custom ESC tap dance (misplaced ELSE)

* Add ability to view and print user configuration

* user_config cosmetics

* various fixes and cosmetics for user_config toggles

* Update readme.md

* RGB backlight timeout indicators completely moved to function key row

* added ability to toggle INS between Shift-DEL and Shift-BKSPC

* Final fix for custom Numpad engage/disengage
       - difference seems to be that return false; needs to be on the (!toggled) case only.
* fix for shift-space functions
@tzarc tzarc merged commit 97dfdcb into qmk:master Jul 2, 2022
casuanoob pushed a commit to casuanoob/qmk_firmware that referenced this pull request Jul 2, 2022
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants