Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quefrency Rev. 5 #17503

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Add Quefrency Rev. 5 #17503

merged 6 commits into from
Jul 11, 2022

Conversation

nooges
Copy link
Member

@nooges nooges commented Jun 29, 2022

Description

  • Add Quefrency Rev. 5
  • Make default65macro be the new default keymap
  • Remove ISO layouts not supported by Rev. 4 & 5 PCBs

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nooges nooges changed the title Fork Quefrency Rev. 5 Add Quefrency Rev. 5 Jun 29, 2022
drashna
drashna requested changes Jul 1, 2022
View reviewed changes
keyboards/keebio/quefrency/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/keebio/quefrency/keymaps/default60/keymap.c Outdated Show resolved Hide resolved
keyboards/keebio/quefrency/keymaps/default60/keymap.c Outdated Show resolved Hide resolved
keyboards/keebio/quefrency/rev5/config.h Outdated Show resolved Hide resolved
@nooges nooges requested a review from drashna July 5, 2022 12:16
@drashna drashna requested a review from a team July 11, 2022 19:00
keyboard-magpie
keyboard-magpie approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of getting to grips with approvals, this all LGTM

@drashna drashna merged commit 9a41a30 into qmk:master Jul 11, 2022
@nooges nooges deleted the quefrency-rev5 branch July 11, 2022 22:02
@nooges nooges mentioned this pull request Jul 12, 2022
Merged
6 tasks
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
@nooges @smocky
[Keyboard] Add Quefrency Rev. 5 (qmk#17503)
ba8bcb1
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@nooges @schattenbrot
[Keyboard] Add Quefrency Rev. 5 (qmk#17503)
23b17c2
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@nooges @imhoffman
[Keyboard] Add Quefrency Rev. 5 (qmk#17503)
f650b88
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@nooges @nolanseaton
[Keyboard] Add Quefrency Rev. 5 (qmk#17503)
16cbeee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nooges @drashna @keyboard-magpie