Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kb2040 and sparkfun rp2040 converters #17514

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Add kb2040 and sparkfun rp2040 converters #17514

merged 2 commits into from
Jul 6, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 30, 2022 •
edited
Loading

Description

Adds converters for:

Future iterations will aim to reduce duplication, however boards inheriting boards is proving more invasive than the scope of this PR.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot removed the python label Jun 30, 2022
@zvecr zvecr force-pushed the feature/kb2040_converter branch from 8f1d929 to 183b471 Compare July 2, 2022 03:12
@zvecr zvecr marked this pull request as ready for review July 2, 2022 17:34
@zvecr zvecr force-pushed the feature/kb2040_converter branch from 183b471 to 3ed4382 Compare July 4, 2022 19:41
@zvecr zvecr force-pushed the feature/kb2040_converter branch from 3ed4382 to 084c81e Compare July 4, 2022 19:41
@zvecr zvecr changed the title Add kb2040 converter Add kb2040 and sparkfun rp2040 converters Jul 4, 2022
filterpaper
filterpaper suggested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@filterpaper filterpaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update board names to match boards/QMK_PM2040 folder.

data/mappings/defaults.json Outdated Show resolved Hide resolved
platforms/chibios/converters/promicro_to_kb2040/converter.mk Outdated Show resolved Hide resolved
KarlK90
KarlK90 approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this, except for the issue filterpaper mentioned LGTM!

jepler
jepler reviewed Jul 5, 2022
View reviewed changes
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I could tell (*no testing performed) .../converters/promicro_to_kb2040/_pin_defs.h is correct.

filterpaper
filterpaper approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@filterpaper filterpaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built correctly for Sparkfun and tested on Adafruit.

@KarlK90
Copy link
Member

KarlK90 commented Jul 6, 2022

One last thing, that the converters are available is not apparent because they are not documented. Do you want to add the docs in this PR?

@zvecr
Copy link
Member Author

zvecr commented Jul 6, 2022

My plan was to rework the docs separately, as the Proton C ones make for a less than ideal landing page.

@KarlK90
Copy link
Member

KarlK90 commented Jul 6, 2022

Sounds reasonable 👍

@zvecr zvecr merged commit 744af00 into qmk:develop Jul 6, 2022
@filterpaper filterpaper mentioned this pull request Jul 7, 2022
Merged
14 tasks
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Add kb2040 and sparkfun rp2040 converters (qmk#17514)
a35ee4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler left review comments

@KarlK90 KarlK90 KarlK90 approved these changes

@filterpaper filterpaper filterpaper approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @KarlK90 @jepler @filterpaper