Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead space from Pierce QMK Configurator layout data #17551

Merged
merged 3 commits into from
Jul 3, 2022

Conversation

noroadsleft
Copy link
Member

@noroadsleft noroadsleft commented Jul 3, 2022

Description

  • info.json: remove dead space from Configurator rendering (image)
    • subtract 0.5 from the y value of each key in `LAYOUT_split_3x5_3
  • fix a key sequence error for the Enter and Backspace keys

cc @durken1 (keyboard maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- remove trailing whitespace
- apply four-space indent (which only moved a closing square bracket)
- subtract 0.5 from the `y` value of each key in `LAYOUT_split_3x5_3`
Switches the objects for the Enter and Backspace keys.
@fauxpark fauxpark merged commit d87d537 into qmk:master Jul 3, 2022
@noroadsleft noroadsleft deleted the cf/pierce branch July 4, 2022 17:50
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants