Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nyhxis NFR-70 keyboard #17562

Merged
merged 21 commits into from
Oct 5, 2022
Merged

Add Nyhxis NFR-70 keyboard #17562

merged 21 commits into from
Oct 5, 2022

Conversation

jesperseverinsen
Copy link
Contributor

@jesperseverinsen jesperseverinsen commented Jul 4, 2022 •
edited
Loading

Description

Added the Nyhxis NFR-70 keyboard firmware files

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 4, 2022
@jesperseverinsen jesperseverinsen marked this pull request as ready for review July 4, 2022 18:06
drashna
drashna requested changes Jul 11, 2022
View reviewed changes
keyboards/nyhxis/nfr_70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/keymaps/tsangan/keymap.c Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/readme.md Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/rules.mk Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/rules.mk Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/rules.mk Outdated Show resolved Hide resolved
@jesperseverinsen jesperseverinsen mentioned this pull request Jul 12, 2022
Closed
6 tasks
drashna
drashna previously approved these changes Jul 13, 2022
View reviewed changes
@drashna drashna requested a review from a team July 13, 2022 04:21
zvecr
zvecr requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, keyboards/nyhxis/nfr_70/keymaps/via/readme.md should be removed

keyboards/nyhxis/nfr_70/config.h Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/config.h Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/keymaps/tsangan/keymap.c Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/keymaps/via/keymap.c Show resolved Hide resolved
keyboards/nyhxis/nfr_70/nfr_70.c Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/nfr_70.h Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Jul 21, 2022
View reviewed changes
keyboards/nyhxis/nfr_70/config.h Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/keymaps/via/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Sep 18, 2022
View reviewed changes
keyboards/nyhxis/nfr_70/config.h Outdated Show resolved Hide resolved
@jesperseverinsen jesperseverinsen requested review from fauxpark and zvecr and removed request for zvecr and fauxpark September 20, 2022 06:13
fauxpark
fauxpark requested changes Sep 26, 2022
View reviewed changes
keyboards/nyhxis/nfr_70/config.h Outdated Show resolved Hide resolved
@jesperseverinsen jesperseverinsen requested review from fauxpark and removed request for zvecr September 26, 2022 14:57
fauxpark
fauxpark requested changes Sep 26, 2022
View reviewed changes
keyboards/nyhxis/nfr_70/info.json Outdated Show resolved Hide resolved
keyboards/nyhxis/nfr_70/config.h Outdated Show resolved Hide resolved
@jesperseverinsen
Copy link
Contributor Author

@fauxpark looks like the linting stopped working after removing the config.h file, something you can verify?

@fauxpark
Copy link
Member 

 ☒ 	layouts: 'LAYOUT_ANSI' is not valid under any of the given schemas

Your info.json layouts don't match the .h file.

@tzarc tzarc dismissed drashna’s stale review September 28, 2022 02:54

for some reason ugfx is back...

@jesperseverinsen
Copy link
Contributor Author

@tzarc Seem like i had messed up the syncing of the fork, should be fixed now. There seem to be a bunch of additions to the lib folder, is this ok or did I mess up something again?

fauxpark
fauxpark requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule changes need to be reverted.

keyboards/nyhxis/nfr_70/info.json Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team October 4, 2022 05:41
@drashna drashna merged commit 0e81954 into qmk:master Oct 5, 2022
@jesperseverinsen jesperseverinsen mentioned this pull request Oct 5, 2022
Merged
6 tasks
SjB added a commit to SjB/qmk_firmware that referenced this pull request Oct 12, 2022
@SjB
Merge branch 'master' into sjb/all-keyboard
12d219e 
* master: (147 commits)
  [Keyboard] Add waffling80 Rev B (qmk#18603)
  Enable mouse keys for momokai tap_trio (qmk#18614)
  [Keyboard] adafruit/macropad: Fix typo (qmk#18616)
  Product changes to 1up lineup (qmk#18382)
  width:2 → height:2 for spacetime thumb keys (qmk#18605)
  [Keyboard] Add encoder map support for GMMK Pro (qmk#18600)
  [Keyboard] Add waffling60 Rev D ANSI Hotswap (qmk#18579)
  [Keyboard] Add waffling60 Rev D Solder (qmk#18580)
  Added new issue template for "Other issues" (qmk#18578)
  docs: some typos (qmk#18582)
  RESET → QK_BOOT in nyhxis/nfr_70 (qmk#18607)
  Fixup builds for mechlovin/infinity87. (qmk#18604)
  fix: ps2_interrupt.c failed to compile (qmk#18597)
  Add C++ prerequisite for Fedora. (qmk#18602)
  [Keyboard] Add Nyhxis NFR-70 keyboard (qmk#17562)
  [Docs] Add a note about the print function. (qmk#17737)
  [Keyboard] Twig50 (qmk#18085)
  [Docs] Clarify how to use the bootloader LED for rp2040 (qmk#18585)
  Bump anothrNick/github-tag-action from 1.51.0 to 1.52.0 (qmk#18590)
  define `oled_write_ln_P` as `oled_write_ln` for non-AVR MCUs (qmk#18589)
  ...
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@jesperseverinsen @drashna
@zvecr @fauxpark @quinnyo
[Keyboard] Add Nyhxis NFR-70 keyboard (qmk#17562)
6af50d5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@jesperseverinsen @drashna
@zvecr @fauxpark
[Keyboard] Add Nyhxis NFR-70 keyboard (qmk#17562)
83d34bd 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@jesperseverinsen @drashna
@zvecr @fauxpark @ramonimbao
[Keyboard] Add Nyhxis NFR-70 keyboard (qmk#17562)
f7b1dce 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@jesperseverinsen @drashna
@zvecr @fauxpark @nolanseaton
[Keyboard] Add Nyhxis NFR-70 keyboard (qmk#17562)
90cc668 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jesperseverinsen @fauxpark @drashna @zvecr