Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for gmmk pro rev2 keyboard. #17655

Merged
merged 7 commits into from
Aug 14, 2022
Merged

Added support for gmmk pro rev2 keyboard. #17655

merged 7 commits into from
Aug 14, 2022

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Jul 13, 2022

Description

as the title.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 13, 2022
@itarze itarze requested a review from tzarc July 27, 2022 09:26
tzarc
tzarc requested changes Aug 13, 2022
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also suggest swapping the via keymaps to use encoder map -- VIA has picked up support for encoders using the encoder map functionality.

keyboards/gmmk/pro/rev2/ansi/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/gmmk/pro/rev2/iso/keymaps/via/config.h Outdated Show resolved Hide resolved
@tzarc tzarc requested a review from a team August 13, 2022 13:41
@itarze
Copy link
Contributor Author

itarze commented Aug 13, 2022

All have been dealt with. Please review it again. @tzarc

@itarze itarze requested a review from tzarc August 13, 2022 15:54
@drashna drashna requested a review from a team August 14, 2022 01:37
@tzarc tzarc merged commit e948fa6 into qmk:develop Aug 14, 2022
@waffle87 waffle87 mentioned this pull request Aug 15, 2022
Merged
8 tasks
@bhushan-n
Copy link

How to know if i have rev1 or rev2 gmmk pro? Would be helpful if this info is added in the readme for gmmk pro.

@adophoxia
Copy link
Contributor

@bhushan-n. Bit late, but if it's any worth, Glorious stated over in a reddit post sometime today regarding both revs of the boards.

So, "rev2" in this case probably refers to a version of GMMK PRO with a different chipset that we were preparing just in case to make sure we are ready for chip shortage if it ever comes. Fortunately, we didn't have to go through all this in the end - today's GMMK PRO still includes STM32s, as far as I know.

nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@itarze @nolanseaton
Added support for gmmk pro rev2 keyboard. (qmk#17655)
5325cbf 
Co-authored-by: Joy <chang.li@westberrytech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itarze @bhushan-n @adophoxia @drashna @tzarc