Move Encoder+Encoder Map from generic features #18018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
keymap
via
drashna
force-pushed
the
fix/encoder_plus_map
branch
from
0e3e348
to
1666e14
Compare
github-actions
bot
removed
keymap
via
drashna
force-pushed
the
fix/encoder_plus_map
branch
from
1666e14
to
0ccf338
Compare
fauxpark
approved these changes
Aug 13, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If encoder map is enabled but encoders are not, then it creates a bunch of compilation issues, that are not simple to disentangle.
The simple fix here, with the least changes is to move the feature rules from the
generic_features.mktocommon_features.mkso that the defines are only enabled if encoders are also enabled.Types of Changes
Checklist