Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new-keyboard default for RP2040 bootloader #18100

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fix new-keyboard default for RP2040 bootloader #18100

merged 1 commit into from
Aug 19, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 19, 2022 •
edited
Loading

Description

Missing entry incorrectly sets "custom" which is less than ideal.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team August 19, 2022 00:39
@zvecr zvecr added the bug label Aug 19, 2022
@github-actions github-actions bot added cli qmk cli command python labels Aug 19, 2022
@zvecr zvecr changed the title Fix new-keymap default for RP2040 bootloader Fix new-keyboard default for RP2040 bootloader Aug 19, 2022
@zvecr zvecr merged commit 9550cc4 into qmk:develop Aug 19, 2022
@fauxpark fauxpark mentioned this pull request Aug 25, 2022
Closed
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Fix new-keyboard default for RP2040 bootloader (qmk#18100)
225e74f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark